Upgrade Mono completions #8452
Upgrade Mono completions #8452
Conversation
- rewrite runtime option completions - remove everything else
|
I think I have to discuss (and maybe fix) raised problems with option parsing with Mono developers because they aren't not Fish shell problems. |
|
Until Mono developers fix mono/mono#21318 I can't write normal completions for some commands:
But of course basic completions will be created for them anyway (but in another PR later). |
|
I'll check these completions tomorrow and refresh them to better fit Fish code style. |
| complete -c mono -l ncompile \ | ||
| -d 'Instruct the runtime on the number of times that the method(-s) specified by --compile/--compile-all to be compiled' | ||
| complete -c mono -l stats \ | ||
| -d 'Display information about the work done by the runtime during the execution of an application' |
There was a problem hiding this comment.
how about putting each argument in a new line, for better readability?
There was a problem hiding this comment.
| -d 'Display information about the work done by the runtime during the execution of an application' | |
| complete -c mono \ | |
| -l ncompile \ | |
| -d 'Instruct the runtime on the number of times that the method(-s) specified by --compile/--compile-all to be compiled' | |
| complete -c mono \ | |
| -l stats \ | |
| -d 'Display information about the work done by the runtime during the execution of an application' |
Do you mean smth like that?
There was a problem hiding this comment.
Sorry the location of my comment is off (bug in my review script) it's about the --aot option (and other in that style)
So I meant that instead of
complete -c mono -l aot -f -a 'asmonly bind-to-runtime-version data-outfile direct-icalls'
I'd write
complete -c mono -l aot -f -a '
asmonly
bind-to-runtime-version
data-outfile
direct-icalls
'
though there are arguments for both styles
There was a problem hiding this comment.
Please check it now. ;)
|
Overall this is really great work! |
- prefer short options - fix types - simplify quoting - prefer builtin functions
|
Merged as 1b12719, thanks! |
Description
This PR upgrades mono.fish completions and adds completions for other Mono tools.
TODOs:
monosupportgacutilsupportxspsupportmkbundlesupportmonodissupportikdasmsupportsqlsharpsupportGendarmesupport