Windows command completions

[EmilyGraceSeville7cf]

Description

Advanced command completions for 13 Windows commands.

Main features

• Where option requires smth but path option values are suggested (if exist)
• Where there are two or more mutually exclusive options the first time one of them is suggested (to choose another user have to remove written option)

ToDos

• cmdkey
• reg
• setx
• attrib
• attributes
• choice
• clean
• cleanmgr
• cmd
• comp
• forfiles
• schtasks
• powershell
• __fish_seen_argument clean-up and Windows-style option support
• make concise descriptions

[floam]

(Same goes for VER for example...)

[EmilyGraceSeville7cf]

Are you certain cls even does anything on fish on Windows? My understanding is there is no cls.exe - it is an internal cmd.exe builtin. Not in PATH, right?

Yes, it's my mistake I've created completion for it. I will go through this command list and remove completions for internal cmd commands.

[EmilyGraceSeville7cf]

I've done the small research on manned.org for utils with the same names and found out:

• clean - removes all intermediate files produced by a previous compilation
• comp - compose a message

There is only one "conflicting" completion in zsh-completions - for reg command: _reg.

[EmilyGraceSeville7cf]

Everything is ready, please review this PR and accept if it's good enough. ;)

[zanchey]

If I run this, I get __fish_seen_argument: --windows: unknown option - probably this needs to be

Suggested change

	if __fish_seen_argument --windows 's'
	if __fish_seen_argument -- --windows 's'

[EmilyGraceSeville7cf]

Everything works nice on my machine. 🤔 I've copied completion to my terminal and tested with a fake empty attrib executable.

Maybe I am doing smth wrong which prevents me from reproducing this issue.

[zanchey]

I think this can be rewritten to be similar to other completions with __fish_seen_subcommand and similar. @faho might have a better idea.

[zanchey]

This awk pipeline is pretty gnarly! I think it could be done with Cartesian expansion instead?

[EmilyGraceSeville7cf]

If I do smth like this:

echo prefix_(echo "1
2")

it prints prefix_1 prefix_2. The problem is dealing with embedded spaces:

echo prefix_(echo "1
2 after-space")

How can I print each item on a separate line to pass them as a suggested completions?

[krobelus]

printf "$current_token" is dangerous because `$current_token might contain a format specifier.

How can I print each item on a separate line to pass them as a suggested completions?

You can use printf %s\n instead of echo.

Here's the full Cartesian product expansion:

printf %s\n $current_token(
            printf %s\t%s\n \
                1 Blue \
                2 Green
        )

[zanchey]

Thanks for this massive contribution!

Before merging I think it needs to be brought into line with the way most of the other completions are written. That means shortening descriptions, using more complete statements and delegating less to functions, and making the function names more consistent (generally __fish_print_xyz for functions that output lists, and __fish_complete_xyz for functions that output item-description pairs). I've left a hodgepodge of comments above along these lines, but it applies to the majority of files.

It might be easier to just work on one or two at a time, if you like.

[ridiculousfish]

Rebased and merged ending at cdae653, relnoted at 30216b2 . Thank you!