Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completions for mathematical tools #8505

Closed
wants to merge 10 commits into from
Closed

Completions for mathematical tools #8505

wants to merge 10 commits into from

Conversation

EmilyGraceSeville7cf
Copy link
Contributor

@EmilyGraceSeville7cf EmilyGraceSeville7cf commented Nov 30, 2021

Description

Completions for mathematical tools.

TODOs:

  • octave
  • matlab

@EmilyGraceSeville7cf EmilyGraceSeville7cf marked this pull request as draft November 30, 2021 09:22
@EmilyGraceSeville7cf EmilyGraceSeville7cf changed the title Completions mathematical tools Completions for mathematical tools Nov 30, 2021
EmilySeville7cfg added 3 commits November 30, 2021 20:39
- --line-editing and --no-line-editing are considered mutually exclusive
@EmilyGraceSeville7cf EmilyGraceSeville7cf marked this pull request as ready for review November 30, 2021 11:45
EmilySeville7cfg added 3 commits December 2, 2021 19:03
@EmilyGraceSeville7cf
Copy link
Contributor Author

EmilyGraceSeville7cf commented Dec 2, 2021

@krobelus, are tests failing due to #8509 fix?

@krobelus
Copy link
Member

krobelus commented Dec 2, 2021 via email

EmilySeville7cfg added 3 commits December 3, 2021 10:16
- respect file extensions
- respect file extensions
- missing opts add
- use --exclusive
- reformat
- fix mistakes
@@ -0,0 +1,77 @@
# Completion for: MATLAB R2021b

function __matlab_check_no_desktop_nodesktop_opts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
function __matlab_check_no_desktop_nodesktop_opts
function __fish__matlab_check_no_desktop_nodesktop_opts

complete --command octave --short-option v --long-option version --description 'Show version'

complete --command octave --long-option built-in-docstrings-file --require-parameter \
--description 'Use docs for built-ins'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use short options for common flags like -d

@@ -0,0 +1,65 @@
# Completion for: GNU Octave 5.2.0

Copy link
Member

@krobelus krobelus Dec 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$status is the implicit return value, you can drop return $status

--description 'Disable the display of figure windows'
complete --command matlab --old-option nosplash \
--description 'Don\'t display the splash screen during startup'
complete --command matlab --old-option nodisplay \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please squash your commits

@zanchey zanchey added this to the fish 3.4.0 milestone Jan 23, 2022
@zanchey zanchey self-assigned this Jan 23, 2022
@zanchey
Copy link
Member

zanchey commented Jan 23, 2022

I addressed the feedback and style issues, and rebased with:
To github.com:fish-shell/fish-shell.git
229e315..36699d4 master -> master

@zanchey zanchey closed this Jan 23, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants