Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in __fish_tokenizer_state #8550

Merged
merged 1 commit into from Dec 13, 2021
Merged

Fix typo in __fish_tokenizer_state #8550

merged 1 commit into from Dec 13, 2021

Conversation

EmilyGraceSeville7cf
Copy link
Contributor

Description

It seems str is a typo because it's never used.

TODOs:

  • Changes to fish usage are reflected in user documentation/manpages.
  • Tests have been added for regressions fixed
  • User-visible changes noted in CHANGELOG.rst

@floam floam added the bug Something that's not working as intended label Dec 13, 2021
@floam
Copy link
Member

floam commented Dec 13, 2021

Bug introduced 4c1173f

@floam floam merged commit e25b719 into fish-shell:master Dec 13, 2021
@floam floam added this to the fish 3.4.0 milestone Dec 13, 2021
@zanchey
Copy link
Member

zanchey commented Dec 15, 2021

Has anyone worked out how to trigger misbehaviour in fish_clipboard_paste as a result of this?

@krobelus
Copy link
Member

When trying to paste these three lines

'
'
    not quoted, so this line should be trimmed

we'd fail to trim spaces from line three, because we didn't realize that the single quote was already closed.

even worse, we mangled quoted data -- we trimmed line three here:

'
' '
    quoted, so this line should not be trimmed

Very nice find, thanks!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something that's not working as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants