Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add isatty completion #8609

Merged
merged 2 commits into from
Jan 8, 2022
Merged

Add isatty completion #8609

merged 2 commits into from
Jan 8, 2022

Conversation

kidonng
Copy link
Contributor

@kidonng kidonng commented Jan 3, 2022

Description

Even though isatty is not very useful interactively, completions will help if the user is interactively writing a function which uses isatty.

TODOs:

  • Changes to fish usage are reflected in user documentation/manpages.
  • Tests have been added for regressions fixed
  • User-visible changes noted in CHANGELOG.rst

@faho faho added this to the fish 3.4.0 milestone Jan 8, 2022
@faho faho merged commit 491dd92 into fish-shell:master Jan 8, 2022
@faho
Copy link
Member

faho commented Jan 8, 2022

Merged, thanks!

@kidonng kidonng deleted the patch-11 branch January 21, 2022 11:52
@kidonng kidonng mentioned this pull request Mar 28, 2022
Merged
3 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
completions enhancement
Projects
None yet
Milestone
fish 3.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@kidonng @faho