New -n flag for string join. #8774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an argument that excludes empty result items. Fixes fish-shell#8351
The new argument --no-empty was added at string-join manpage.
The reason to remove this new argument in the join0 is that this flag basically doesn't make any difference in the join0.
|
Fixes #8351 |
faho
reviewed
Mar 10, 2022
|
Seems okay to me, I'll wait with merging until after 3.4.0 is out (which we're hoping to get done soon). |
The string join command was using the length of the argument, this commit changes the validation to use the empty function.
The reason for the revert is thath the build broke on the ubuntu in the Github actions.
The reason the compilation on GitHub broke is that the test was weird, it didn't even run it, Common CI systems are typically very very resource-constrained.
commit #1242d0fd7 not fixed all conflicts.
|
Merged, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flag jumps the delimiter for empty items.