feat(completions): add sops completions

[budimanjojo]

Description

Add SoPS shell completion.

Issue I can't solve

• I don't know how to check if previous primary flag is a flag that require value. For example, when I want to type in: sops --add-age "value" --decrypt If I type in sops --add-age and put in the value that it needs, then I type in --, it should give me list of flags that I can put in after that, but it shows me nothing but global flag. The workaround for user is to type it in like this sops --add-age="value" --decrypt

TODOs:

• I still need help in the issue above

[krobelus]

Can you try to replace uses of this function with __fish_seen_subcommand_from?

I believe if there are multiple levels of subcommands, it's okay to use __fish_seen_subcommand_from subcmd && __fish_seen_subcommand_from subsubcmd (not always fully correct but good enough)

[budimanjojo]

Do you mean deleting this whole __fish_sops_commands function and use __fish_seen_subcommand_from instead?

[krobelus]

Do you mean deleting this whole __fish_sops_commands function and use __fish_seen_subcommand_from instead?

yep

[krobelus]

even better, replace it with a function that uses argparse to decide which subcommand is active (similar to __fish_sudo_print_remaining_args)

[budimanjojo]

The reason why I didn't use __fish_seen_subcommand_from subcmd1 && __fish_seen_subcommand_from subcmd2 for multiple levels subcommands is because it accepts anything as long as there are the word subcmd1 and subcmd2 ignoring the placement. For example, if I want group as subcmd1 and add as subcmd2 then even if I write it as sops blablabla add groups it will still return true. While the function that I'm using it right now (I took the code from __btrfs_commands and __btrfs_command_groups) will return false unless the command is sops groups add and nothing else.

[budimanjojo]

I might go with the even better "similar to __fish_sudo_print_remaining_args" approach, but it might need some time because I'm still figuring out how does argparse work. T.T

[krobelus]

Ok makes sense. I think copying __fish_sudo_print_remaining_args is the way to go. We should probably add more examples to the argparse docs.

[budimanjojo]

I have modified the way it works, please have another look @krobelus. I don't know if the code is good as I'm not experienced enough for this (not even sure what I did lol), please correct my code if needed. :)

[budimanjojo]

@krobelus Thanks for the reviews! I have commited some of your suggestions, and commented on those I don't quite understand. Please have another look :)
I don't know why the check is not successful though, completion files shouldn't affect builds right?

[krobelus]

I don't know why the check is not successful though, completion files shouldn't affect builds right?

yeah, no need to worry. We have some flaky tests.

[krobelus]

Thanks!