Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra resource limits to ulimit #8823

Merged
merged 5 commits into from
Mar 24, 2022
Merged

Conversation

zanchey
Copy link
Member

@zanchey zanchey commented Mar 21, 2022

I've been through the manual pages for Linux, and added most of the the resource
limits that aren't already available. I skipped RLIMIT_LOCKS because it only
applies to long-obsolete versions of the kernel.

Fixes issue #8786.

TODOs:

  • Changes to fish usage are reflected in user documentation/manpages.
  • Tests have been added for regressions fixed
  • User-visible changes noted in CHANGELOG.rst

@zanchey zanchey added this to the fish 3.5.0 milestone Mar 21, 2022
@zanchey zanchey linked an issue Mar 21, 2022 that may be closed by this pull request
src/builtins/ulimit.cpp Outdated Show resolved Hide resolved
@zanchey zanchey force-pushed the ulimit-upgrades branch 3 times, most recently from 8360fd7 to b9c1bd5 Compare March 23, 2022 15:17
@zanchey
Copy link
Member Author

zanchey commented Mar 23, 2022

I've included the macros from NetBSD and FreeBSD, added some basic tests, updated the completions and the documentation, and made the utility return a specific error if the option is valid but not supported.

Copy link
Member

@faho faho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zanchey zanchey merged commit 6a8efa3 into fish-shell:master Mar 24, 2022
@zanchey zanchey self-assigned this Mar 24, 2022
@zanchey zanchey deleted the ulimit-upgrades branch March 25, 2022 13:11
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose more limits in ulimit
2 participants