Print message in set_fish_path -v when a path doesnt exist #8884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Im frankly baffled why autosuggest_suggest_special is failing, and can't reproduce it locally. I didn't change any code relating to that at all |
Yeah the current Github Actions ASAN appears to be broken, it's crashing in that test. Nothing to do with your PR at all. |
faho
requested changes
Apr 18, 2022
|
Merged, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While debugging something that uses fish_add_path I got confused why it wasn't doing anything, and it turned out to be the path not existing. I figured it should print a message when a path gets skipped when using -v. behavior outside verbose mode is unchanged.
TODOs:
[ ] Tests have been added for regressions fixedN/A