Remove invalid trailing period in CSI u shift-space binding #9054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krobelus
reviewed
Jul 4, 2022
| @@ -188,7 +188,7 @@ function __fish_shared_key_bindings -d "Bindings shared between emacs and vi mod | |||
| # Ctrl-space inserts space without expanding abbrs | |||
| bind --preset $argv -k nul 'test -n "$(commandline)" && commandline -i " "' | |||
| # Shift-space (CSI u escape sequence) behaves like space because it's easy to mistype. | |||
| bind --preset $argv \e\[32\;2u 'commandline -i " "; commandline -f expand-abbr'. | |||
| bind --preset $argv \e\[32\;2u 'commandline -i " "; commandline -f expand-abbr' | |||
There was a problem hiding this comment.
Thanks for the fix, will add to the 3.5.1 branch.
For the record, here's how to reproduce the problem with xterm:
printf '%s\n' 'XTerm.vt100.formatOtherKeys: 1' 'XTerm.vt100.modifyOtherKeys: 2' | xrdb && xterm -e fish
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes a trailing period that resulted in the following error:
...when typing shift-space.
TODOs: