Add Firefox completions #9090
Merged
Add Firefox completions #9090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daanturo
force-pushed
the
firefox-completions
branch
2 times, most recently
from
c564347 to
9f0d57c
Compare
krobelus
reviewed
Aug 4, 2022
share/completions/firefox.fish
Outdated
| complete -c firefox -l new-instance -d "Open new instance, not a new window in running instance" | ||
| complete -c firefox -l safe-mode -d "Disables extensions and themes for this session" | ||
| complete -c firefox -l allow-downgrade -d "Allows downgrading a profile" | ||
| complete -c firefox -l MOZ_LOG -r -d "Treated as MOZ_LOG=<modules> environment variable, overrides it" |
There was a problem hiding this comment.
since this never takes file arguments, we could suppress them with -f
daanturo
force-pushed
the
firefox-completions
branch
3 times, most recently
from
6bfa43c to
ec97fdf
Compare
krobelus
reviewed
Aug 9, 2022
share/completions/firefox.fish
Outdated
| complete -c firefox -l private-window -r -d "Open <url> in a new private window" | ||
| complete -c firefox -l preferences -d "Open Preferences dialog" | ||
| complete -c firefox -l screenshot -d "Save screenshot to <path> or in working directory" | ||
| complete -c firefox -f -l window-size -d "Width and optionally height of screenshot" |
There was a problem hiding this comment.
this should have -r (AKA --require-parameter)
share/completions/firefox.fish
Outdated
| complete -c firefox -f -l new-instance -d "Open new instance, not a new window in running instance" | ||
| complete -c firefox -f -l safe-mode -d "Disables extensions and themes for this session" | ||
| complete -c firefox -f -l allow-downgrade -d "Allows downgrading a profile" | ||
| complete -c firefox -l MOZ_LOG -r -d "Treated as MOZ_LOG=<modules> environment variable, overrides it" |
There was a problem hiding this comment.
small misunderstanding: I meant only the --MOZ_LOG should have -f. Not the other flags like --new-instance, they don't take any parameters anyway
I'll correct both and merge. Thanks for the contribution!
krobelus
force-pushed
the
firefox-completions
branch
from
ec97fdf to
2a9d63c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add firefox completions
Fixes issue: None
TODOs: