Add powershell support to suppress UNC path error #9119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prefer using powershell.exe over cmd.exe on wsl to supress terminal error: "CMD.EXE was started with the above path as the current directory"
A recent commit added an invalid expression to the help.fish script. The "-z" flag caused the error: "test: Missing close paren at index 11"
spiffcs
changed the title
faho
reviewed
Aug 8, 2022
share/functions/help.fish
Outdated
| # Try and see if powershell.exe is an option to avoid UNC path error | ||
| # https://ss64.com/nt/cmd.html Launching CMD/batch files from a UNC path | ||
| if type -q powershell.exe | ||
| set fish_browser powershell.exe |
There was a problem hiding this comment.
This should be inside the WSL if above.
Make it
and set -l cmd (command -s powershell.exe cmd.exe /mnt/c/Windows/System32/cmd.exe)(powershell isn't in /mnt/c/Windows/System32 but /mnt/c/Windows/System32/WindowsPowerShell/v1.0/powershell.exe, I don't think we can hardcode the version number like that, so just the normal $PATH lookup can stay)
There was a problem hiding this comment.
updated conditional with the above and statement and set fish_browser as $cmd[1]
faho
reviewed
Aug 8, 2022
|
Thanks for the review @faho! Updates incorporated to the PR. Thanks also for all the fish-shell support. |
faho
reviewed
Aug 8, 2022
faho
reviewed
Aug 8, 2022
|
Merged, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
powershell.exeovercmd.exeon wsl to supress terminal error:CMD.EXE was started with the above path as the current directoryFollow up to issue #6338
Before:
After:
Previous change that caused the
missing close parenerror linked hereff2999e
TODOs: