Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commandline --selection-start and --selection-end implementation #9215

Merged
merged 3 commits into from
Oct 5, 2022

Conversation

sshilovsky
Copy link
Contributor

@sshilovsky sshilovsky commented Sep 17, 2022

Related to #9197

I figure selection-start makes more sense for the left side of the selection, than for the one farther from cursor; also along with naming in code.

Please review. If this is all right, I'll update the docs.

@faho faho merged commit e274ef6 into fish-shell:master Oct 5, 2022
@faho faho added this to the fish 3.6.0 milestone Oct 5, 2022
@faho
Copy link
Member

faho commented Oct 5, 2022

Merged, thanks!

(I was a bit confused as to why this was "start" and "end()" - turns out we store the start and length and so "end()" is a method that returns start+length)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants