Skip to content

Add completions for direnv#9268

Merged
faho merged 2 commits intofish-shell:masterfrom
xanderio:direnv-completions
Oct 14, 2022
Merged

Add completions for direnv#9268
faho merged 2 commits intofish-shell:masterfrom
xanderio:direnv-completions

Conversation

@xanderio
Copy link
Contributor

@xanderio xanderio commented Oct 9, 2022

Description

Talk about your changes here.

Fixes issue #

TODOs:

  • Changes to fish usage are reflected in user documentation/manpages.
  • Tests have been added for regressions fixed
  • User-visible changes noted in CHANGELOG.rst

complete -c direnv -n "not __fish_seen_subcommand_from $commands" \
-a exec -d "Executes a command after loading the first .envrc or .env found in DIR"
complete -c direnv -n "not __fish_seen_subcommand_from $commands" \
-a fetchurl -d "Fetches a given URL into direnv's CAS"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's "CAS" in this context?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wording is directly copied from direnv --help and even after looking at the source code I have no concrete answer to this. It probably stands for Content Addressable Storage, but that's just an adjudicated guess.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tbh I'd suggest to upstream to rephrase that. Until then it's good enough for us.

@faho faho merged commit 8f394f5 into fish-shell:master Oct 14, 2022
@faho
Copy link
Member

faho commented Oct 14, 2022

Merged, thanks!

@faho faho added this to the fish 3.6.0 milestone Oct 14, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants