Skip to content

Add readelf completions #9386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 14, 2022
Merged

Conversation

xfgusta
Copy link
Contributor

@xfgusta xfgusta commented Nov 26, 2022

Description

This targets readelf from binutils. There are some variants like elftoolchain and elfutils. Because I don't know how to handle variants and I don't know them very well, I picked the most popular one. They seem to be quite similar, though.

Fixes issue #8746

TODOs:

  • Changes to fish usage are reflected in user documentation/manpages.
  • Tests have been added for regressions fixed
  • User-visible changes noted in CHANGELOG.rst

@krobelus
Copy link
Contributor

nice work! I'll wait a bit before merging, in case you'd like to incorporate the feedback.

@xfgusta xfgusta requested a review from krobelus December 14, 2022 02:34
@krobelus krobelus merged commit b5470fc into fish-shell:master Dec 14, 2022
@krobelus krobelus added this to the fish 3.6.0 milestone Dec 14, 2022
@xfgusta xfgusta deleted the add-readelf-completions branch December 14, 2022 22:17
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants