Remove str2wcs special case for MB_CUR_MAX #9473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This meant we didn't actually do our weird en/decoding scheme for e.g. a C locale, which meant that, when you then switch to a proper locale the previous variables were broken. I don't know how to test this automatically - none of my attempts seem to ever *fail* with the old code, here's what you'd do manually: - Run fish with an actual C locale (LC_ALL=C fish_allow_singlebyte_locale=1 fish) - `set -gx foo 💩` - `set -e LC_ALL` - `echo $foo` outputs "💩" if it works and "ð⏎" if it's broken. Fixes fish-shell#2613
ridiculousfish
approved these changes
Jan 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This meant we didn't actually do our weird en/decoding scheme for e.g. a C locale, which meant that, when you then switch to a proper locale the previous variables were broken.
I don't know how to test this automatically - none of my attempts seem to ever fail with the old code, here's what you'd do manually:
set -gx foo 💩set -e LC_ALLecho $foooutputs "💩" if it works and "ð⏎" if it's broken.Fixes #2613
TODOs: