completions: Offer ../ and ./ again#9477
Merged
faho merged 2 commits intofish-shell:masterfrom Jan 16, 2023
Merged
Conversation
Inadvertently broken in a2d8167, this made `cd .` no longer offer `cd ../` (same for file completions like `ls .`, which only offers dot-files but no more `ls ../` for `ls ../foo`) This adds these paths in one specific case rather than changing dir_iter to always go through them. That should be okay.
faho
added
the
regression
Member
|
Nice find. I think rather than manually inserting these paths, it would be better to have an option in |
ridiculousfish
requested review from
krobelus and
ridiculousfish
and removed request for
krobelus
This was referenced Jan 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inadvertently broken in a2d8167, this made
cd .no longer offercd ../(same for file completions likels ., which only offers dot-files but notls ../)This adds these paths in one specific case rather than changing dir_iter to always go through them. That should be okay.
TODOs: