Skip to content

Conversation

@szuro
Copy link
Contributor

@szuro szuro commented Mar 8, 2023

Description

Adds completions for Zabbix commands

TODOs:

  • Changes to fish usage are reflected in user documentation/manpages.
  • Tests have been added for regressions fixed
  • User-visible changes noted in CHANGELOG.rst

Copy link
Contributor

@mqudsi mqudsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to merge this but some of your descriptions are too long. Descriptions don't get a lot of room in the pager, can you please trim them down to around 50 chars or so max? They don't have to be full sentences.

@szuro
Copy link
Contributor Author

szuro commented Mar 22, 2023

Shortened some of the descriptions

@mqudsi mqudsi added this to the fish 3.6.2 milestone Apr 1, 2023
@mqudsi mqudsi merged commit 9bd1dc1 into fish-shell:master Apr 1, 2023
faho pushed a commit that referenced this pull request Sep 8, 2023
Add Zabbix completions

(cherry picked from commit 9bd1dc1)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants