Merged
Conversation
Add basic command completion for rpm-ostree. This should improve the user experience for fish users using rpm-ostree.
mqudsi
requested changes
Mar 22, 2023
Contributor
mqudsi
left a comment
mqudsi
left a comment
There was a problem hiding this comment.
Thanks for these - they look good but the descriptions are too long. Descriptions don't get too much room in the pager, can you try to keep them below 50 chars or so max? They don't have to be full sentences, perfect grammar, etc - just enough to convey the message.
faho
pushed a commit
that referenced
this pull request
Oct 1, 2023
* Add rpm-ostree completion Add basic command completion for rpm-ostree. This should improve the user experience for fish users using rpm-ostree. * Shorten rpm-ostree descriptions --------- Co-authored-by: Mahmoud Al-Qudsi <mqudsi@neosmart.net> (cherry picked from commit 20b500d)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add basic command completion for rpm-ostree. Fedora 37 Silverblue and Kinoite use rpm-ostree as their hybrid image/package system.
This should improve the user experience for fish users using rpm-ostree.
Fixes issue #
TODOs: