Skip to content

Conversation

@asukaminato0721
Copy link
Contributor

Description

add-qjsc-fish

fish_indent -w is done.

Fixes issue #

TODOs:

  • Changes to fish usage are reflected in user documentation/manpages.
  • Tests have been added for regressions fixed
  • User-visible changes noted in CHANGELOG.rst

Copy link
Member

@faho faho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these options do not appear to exist, at least in the documentation I've found.

Please double-check that they do in the version you have.

This is the issue with AI-generation - it appears to save time, but you have to double-check everything, which ends up wasting our time.

@asukaminato0721
Copy link
Contributor Author

Some of these options do not appear to exist, at least in the documentation I've found.

Please double-check that they do in the version you have.

I install the latest version of qjs, it brings qjsc, then I rewrite according to qjsc --help

@asukaminato0721
Copy link
Contributor Author

I've added the origin input to the fish file.

@faho faho added this to the fish 3.6.2 milestone Apr 19, 2023
@faho faho merged commit f5e063a into fish-shell:master Apr 19, 2023
@faho
Copy link
Member

faho commented Apr 19, 2023

Thanks, merged.

@asukaminato0721 asukaminato0721 deleted the add-qjsc-fish branch April 23, 2023 19:22
faho pushed a commit that referenced this pull request Oct 1, 2023
* add-qjsc-fish

* fix -o qjsc.fish

(cherry picked from commit f5e063a)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants