Skip to content

improved print CSS for fish_config #9828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 10, 2023
Merged

improved print CSS for fish_config #9828

merged 2 commits into from
Jun 10, 2023

Conversation

korve
Copy link

@korve korve commented Jun 2, 2023

Description

This commit introduces a fishconfig_print.css that contains special CSS styles that only apply when printing the fishconfig page. This is especially useful when the user wants to print out the key bindings.

Also the filter input is now hidden when printing any of the tabs on the config page.

Before:

before

After:

after

TODOs:

  • Changes to fish usage are reflected in user documentation/manpages.
  • Tests have been added for regressions fixed
  • User-visible changes noted in CHANGELOG.rst

Andre Eckardt added 2 commits June 2, 2023 14:07
This commit introduces a fishconfig_print.css that contains special CSS styles that only apply when printing the fishconfig page. This is especially useful when the user wants to print out the key bindings.
@Xiretza
Copy link
Contributor

Xiretza commented Jun 2, 2023

The result looks great! Something that would probably be good for the regular stylesheet as well: could the right column's width be reduced to fit as much of the left column as possible, rather than always splitting the page in the middle? The bindings are almost always longer than the key sequences.

@korve
Copy link
Author

korve commented Jun 5, 2023

The result looks great! Something that would probably be good for the regular stylesheet as well: could the right column's width be reduced to fit as much of the left column as possible, rather than always splitting the page in the middle? The bindings are almost always longer than the key sequences.

Its kinda difficult to find a width for every screen/orientation so the right column doesn't get too small. Also, you can expand rows when clicking on them, so more content is revealed on the right column.

Some keys are really weird, for example commandline\ -f\ expand-abbr\;\ commandline\ -i\ \\n. What does it even do? Maybe more descriptive keys would be a better solution?

@faho faho merged commit cbf9a3b into fish-shell:master Jun 10, 2023
@faho faho added this to the fish 3.6.2 milestone Jun 10, 2023
@faho
Copy link
Member

faho commented Jun 10, 2023

Merged, thanks!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants