New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Events of close relatives' only listed for first associate #1192

Open
ric2016 opened this Issue Jan 22, 2017 · 6 comments

Comments

Projects
None yet
5 participants
@ric2016
Contributor

ric2016 commented Jan 22, 2017

This bug has been discussed as while ago in https://www.webtrees.net/index.php/en/forum/help-for-ver-1-7-4/31323-how-to-add-other-kind-of-related-person, but apparently not reported here:

On the 'Facts and Events' tab, in the list of 'Events of close relatives' of an Individual Ix, an associate event is only displayed if Ix is listed as the first associate of the respective event (e.g. as the first godparent).

This is because associateFacts in IndividualFactsTabModule.php only checks for the first attribute ($fact->getAttribute('_ASSO')/$fact->getAttribute('ASSO')). Here, all ASSO/_ASSO attributes should be used instead, e.g. via a new function in Fact.php:

public function getAttributes($tag) {
	preg_match_all('/\n2 (?:' . $tag . ') ?(.*(?:(?:\n3 CONT ?.*)*)*)/', $this->gedcom, $matches);
	$attributes = array();
	foreach ($matches[1] as $match) {
		$attributes[] = preg_replace("/\n3 CONT ?/", "\n", $match);
	}
	return $attributes;
}
@apberger

This comment has been minimized.

Show comment
Hide comment
@apberger

apberger May 17, 2018

Is there any idea, when this issue will be solved?

apberger commented May 17, 2018

Is there any idea, when this issue will be solved?

@Joppla

This comment has been minimized.

Show comment
Hide comment
@Joppla

Joppla Sep 14, 2018

This item is closed, but the bug is not solved in v 1.7.11

Joppla commented Sep 14, 2018

This item is closed, but the bug is not solved in v 1.7.11

@ric2016

This comment has been minimized.

Show comment
Hide comment
@ric2016

ric2016 Sep 14, 2018

Contributor

Where do you see that this issue is closed?

Contributor

ric2016 commented Sep 14, 2018

Where do you see that this issue is closed?

@fisharebest

This comment has been minimized.

Show comment
Hide comment
@fisharebest

fisharebest Sep 14, 2018

Owner

This item is closed

This issue is not closed. Issue #1267 is closed, and #1267 has a reference to this issue.

Owner

fisharebest commented Sep 14, 2018

This item is closed

This issue is not closed. Issue #1267 is closed, and #1267 has a reference to this issue.

@Joppla

This comment has been minimized.

Show comment
Hide comment
@Joppla

Joppla Sep 14, 2018

misunderstanding, sorry, in the title I saw "close" and here also:
afbeelding
But now I understand that it is a link to the other item.

Any idea when the item will be solved?

Joppla commented Sep 14, 2018

misunderstanding, sorry, in the title I saw "close" and here also:
afbeelding
But now I understand that it is a link to the other item.

Any idea when the item will be solved?

@AndreasRauhut

This comment has been minimized.

Show comment
Hide comment
@AndreasRauhut

AndreasRauhut Sep 20, 2018

Contributor

Me too, I would like that somebody will do the neccessary to solve the bug and close the issue.
Unfortunately I'm not the right person to do it.

Contributor

AndreasRauhut commented Sep 20, 2018

Me too, I would like that somebody will do the neccessary to solve the bug and close the issue.
Unfortunately I'm not the right person to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment