Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 Beta3 Openstreetmap error when using flags #2436

Closed
ddrury opened this issue May 14, 2019 · 2 comments
Closed

2 Beta3 Openstreetmap error when using flags #2436

ddrury opened this issue May 14, 2019 · 2 comments

Comments

@ddrury
Copy link
Contributor

@ddrury ddrury commented May 14, 2019

If we have flags stored at Modules_v4/openstreetmap/places then they are not displayed on the Places Hierarchy page (assuming Maps are used). I think the solution is to change line 274 of PlaceHierarchyController from Webtrees::MODULES_DIR . 'openstreetmap/'; to Webtrees::MODULES_PATH. '/openstreetmap/';

However now that openstreetmaps is no longer a module wouldn't it make more sense to store the flags somewhere else (resources?)

@ddrury ddrury changed the title Openstreetmap error when using flags 2 Beta3 Openstreetmap error when using flags May 14, 2019
@fisharebest
Copy link
Owner

@fisharebest fisharebest commented May 14, 2019

The only folder to which we can/should write is /data

Not only is the modules_v4 folder not guaranteed to be writable, all assets (css, js, png, etc.) need to be in /public, as this will be the base-url when we move to "pretty URLs".

Storing flags in the database might be an option - and then embedding them as data: URLs in the page.

See #1797

@fisharebest fisharebest added this to the 2.0.0 milestone Jun 11, 2019
@fisharebest fisharebest removed this from the 2.0.0 milestone Aug 26, 2019
@fisharebest fisharebest added this to the 2.1.0 milestone Aug 26, 2019
@fisharebest fisharebest removed this from the 2.1.0 milestone Jun 25, 2020
@fisharebest
Copy link
Owner

@fisharebest fisharebest commented Feb 1, 2021

Closed in favour of #3698

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants