Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve "get_column_values returns an error if passed a `ref`, but the model has not been previously built" #152

Merged
merged 2 commits into from Jul 24, 2019

Conversation

@emilieschario
Copy link
Contributor

commented Jul 23, 2019

Closes #119

This PR updates the get column values macro to take an optional default argument that can be used when the ref'd relation does not already exist. This is notable in cases when running dbt compile.

Passing tests are: https://circleci.com/gh/fishtown-analytics/dbt-utils/330?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

emilieschario added some commits Jul 23, 2019

@drewbanin

This comment has been minimized.

Copy link
Contributor

commented Jul 23, 2019

Screen Shot 2019-07-23 at 6 12 36 PM

woop woop!

@emilieschario

This comment has been minimized.

Copy link
Contributor Author

commented Jul 23, 2019

@drewbanin only took since May 18 😄

@drewbanin
Copy link
Contributor

left a comment

Thanks for all of your hard work on this one @emilieschario - approved!

This will go out in dbt-utils v0.2.1 tomorrow!

@drewbanin drewbanin merged commit c8991e6 into fishtown-analytics:master Jul 24, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
@clrcrl clrcrl referenced this pull request Jul 26, 2019
3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.