New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include datasets with underscores when listing BigQuery datasets #954

Closed
wants to merge 1 commit into
base: development
from

Conversation

Projects
None yet
3 participants
@k4y3ff
Copy link
Contributor

k4y3ff commented Aug 28, 2018

Pretty sure I ran into the same thing @rsmichaeldunn ran into in #873?

Here's a PR.

shrug

@drewbanin

This comment has been minimized.

Copy link
Contributor

drewbanin commented Aug 28, 2018

hey @k4y3ff -- thanks for the PR! This looks great!

I haven't seen this error in the wild yet, so I don't have a great understanding of BigQuery's semantics here. I can dig into this further today, but @rsmichaeldunn also mentioned in the issue:

...and changing the create_schema method to check for the existence of the dataset id in the output of get_existing_schemas instead of using get_dataset

It sounds to me like client.get_dataset(dataset) doesn't return the dataset if it begins with an underscore? Is that consistent with your understanding?

I think it would be really great to add a quick test for this, as the BigQuery client library is updated pretty frequently and this is a super easy thing to miss

@beckjake

This comment has been minimized.

Copy link
Contributor

beckjake commented Sep 18, 2018

Closing this PR, as this contribution was merged in #1006. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment