New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix builder shows "http: multiple response.WriteHeader calls" #1029

Merged
merged 1 commit into from Dec 19, 2018

Conversation

Projects
None yet
1 participant
@life1347
Copy link
Member

life1347 commented Dec 19, 2018

From doc

// WriteHeader sends an HTTP response header with the provided
    // status code.
    //
    // If WriteHeader is not called explicitly, the first call to Write
    // will trigger an implicit WriteHeader(http.StatusOK).
    // Thus explicit calls to WriteHeader are mainly used to
    // send error codes.
    //
    // The provided code must be a valid HTTP 1xx-5xx status code.
    // Only one header may be written. Go does not currently
    // support sending user-defined 1xx informational headers,
    // with the exception of 100-continue response header that the
    // Server sends automatically when the Request.Body is read.
    WriteHeader(statusCode int)

This change is Reviewable

@life1347 life1347 added this to the 1.0-rc2 milestone Dec 19, 2018

@life1347 life1347 force-pushed the fix-builder-multiple-WriteHeader-error branch from 971f11c to 36d09f7 Dec 19, 2018

@life1347 life1347 merged commit 85f8dcc into master Dec 19, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@life1347 life1347 deleted the fix-builder-multiple-WriteHeader-error branch Dec 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment