Repository navigation
Use Header.Set() to override the existing header value - #1032
Merged
Merged
Conversation
life1347
force-pushed
the
fix-router-wrongly-appends-header-value
branch
from
December 19, 2018 14:37
1988fc8 to
61ca318
Compare
Header.Add() appends string if there are same header key exists. Use Header.Set() to prevent this.
life1347
force-pushed
the
fix-router-wrongly-appends-header-value
branch
from
December 19, 2018 17:31
61ca318 to
4d5fb7b
Compare
Member
|
Hi @life1347 Are there use cases where we might want to append headers and not set them? |
Member
Author
|
As far as I know, we don't have such use cases for appending headers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Header.Add() appends string if there are same header key exists. Use Header.Set() to prevent this.
Fix #1027
This change is