Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable go module support for go environment #1152

Merged
merged 6 commits into from Jul 10, 2019

Conversation

@life1347
Copy link
Member

commented Apr 5, 2019

Fix #1130


This change is Reviewable

@soamvasani
Copy link
Member

left a comment

Awesome, LGTM.

@life1347 life1347 force-pushed the go-env-go-mod branch 3 times, most recently from ed19d76 to 6d6a385 Apr 9, 2019

@life1347

This comment has been minimized.

Copy link
Member Author

commented May 9, 2019

Find an issue related to go plugin & go mod, we should not merge this PR until the problem gets resolved/answered.

@vishal-biyani vishal-biyani added this to the 1.4 milestone Jun 20, 2019

@life1347 life1347 force-pushed the go-env-go-mod branch 2 times, most recently from 75a242b to 218b167 Jul 9, 2019

@life1347 life1347 force-pushed the go-env-go-mod branch from 218b167 to 0e763d3 Jul 10, 2019

@life1347 life1347 merged commit 58722f8 into master Jul 10, 2019

6 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - environments/jvm/pom.xml (soamvasani) No new issues
Details
security/snyk - environments/nodejs/package.json (soamvasani) No manifest changes detected
security/snyk - environments/python/requirements.txt (soamvasani) No manifest changes detected
security/snyk - environments/ruby/Gemfile.lock (soamvasani) No manifest changes detected
security/snyk - examples/nodejs/package.json (soamvasani) No manifest changes detected

@life1347 life1347 deleted the go-env-go-mod branch Jul 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.