Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kafka connector namespace issue #2298

Merged
merged 1 commit into from Jan 11, 2022
Merged

Conversation

blackfly19
Copy link
Contributor

Description

Kafka connector deployment issue if default namespace is not used.

Which issue(s) this PR fixes:

Fixes #1987 #2242

Testing

Tried kafka triggers in different namespaces.

Checklist:

  • I ran tests as well as code linting locally to verify my changes.
  • I have done manual verification of my changes, changes working as expected.
  • I have added new tests to cover my changes.
  • My changes follow contributing guidelines of Fission.
  • I have signed all of my commits.

@blackfly19 blackfly19 changed the title Minor bug fixes Kafka connector namespace issue Jan 10, 2022
@codecov
Copy link

codecov bot commented Jan 10, 2022

Codecov Report

Merging #2298 (94586fa) into master (89f80c6) will not change coverage.
The diff coverage is 0.00%.

❗ Current head 94586fa differs from pull request most recent head ff67db3. Consider uploading reports for the commit ff67db3 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2298   +/-   ##
=======================================
  Coverage   19.11%   19.11%           
=======================================
  Files          56       56           
  Lines        6142     6142           
=======================================
  Hits         1174     1174           
  Misses       4884     4884           
  Partials       84       84           
Flag Coverage Δ
unittests 19.11% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/mqtrigger/scalermanager.go 26.30% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89f80c6...ff67db3. Read the comment docs.

@sanketsudake sanketsudake self-requested a review January 11, 2022 07:09
@sanketsudake sanketsudake added the documentation All issues related to docs repo: https://github.com/fission/docs.fission.io label Jan 11, 2022
@sanketsudake sanketsudake added this to the 1.16.0 milestone Jan 11, 2022
@sanketsudake
Copy link
Member

@Mergifyio rebase

@sanketsudake sanketsudake linked an issue Jan 11, 2022 that may be closed by this pull request
@sanketsudake sanketsudake merged commit 89aedda into master Jan 11, 2022
@sanketsudake sanketsudake deleted the connectorNamespaceIssue branch January 11, 2022 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation All issues related to docs repo: https://github.com/fission/docs.fission.io
Projects
None yet
2 participants