Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable promlinter and enhance exposed metrics. #2550

Merged
merged 2 commits into from Sep 20, 2022
Merged

Enable promlinter and enhance exposed metrics. #2550

merged 2 commits into from Sep 20, 2022

Conversation

kanuahs
Copy link
Contributor

@kanuahs kanuahs commented Sep 19, 2022

Description

Which issue(s) this PR fixes:

Fixes #

Testing

Checklist:

  • I ran tests as well as code linting locally to verify my changes.
  • I have done manual verification of my changes, changes working as expected.
  • I have added new tests to cover my changes.
  • My changes follow contributing guidelines of Fission.
  • I have signed all of my commits.

@kanuahs kanuahs changed the title Enable promlinter Enable promlinter and enhance exposed metrics. Sep 19, 2022
@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

Merging #2550 (ed9de69) into main (dc4c6e2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2550   +/-   ##
=======================================
  Coverage   18.78%   18.78%           
=======================================
  Files          62       62           
  Lines        6766     6766           
=======================================
  Hits         1271     1271           
  Misses       5393     5393           
  Partials      102      102           
Flag Coverage Δ
unittests 18.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sanketsudake sanketsudake marked this pull request as ready for review September 20, 2022 04:52
@sanketsudake sanketsudake merged commit b19d18c into fission:main Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants