Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with updating timetrigger without --cron flag #2677

Merged
merged 3 commits into from Dec 28, 2022

Conversation

shubham4443
Copy link
Contributor

Signed-off-by: Shubham Nazare shubham4443@gmail.com

Description

Simply removed the condition.

Which issue(s) this PR fixes:

Fixes #2596

Testing

Checklist:

  • I ran tests as well as code linting locally to verify my changes.
  • I have done manual verification of my changes, changes working as expected.
  • I have added new tests to cover my changes.
  • My changes follow contributing guidelines of Fission.
  • I have signed all of my commits.

Signed-off-by: Shubham Nazare <shubham4443@gmail.com>
@codecov
Copy link

codecov bot commented Dec 24, 2022

Codecov Report

Merging #2677 (4a47fd9) into main (8df4fd0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2677   +/-   ##
=======================================
  Coverage   21.13%   21.13%           
=======================================
  Files          65       65           
  Lines        7211     7211           
=======================================
  Hits         1524     1524           
  Misses       5573     5573           
  Partials      114      114           
Flag Coverage Δ
unittests 21.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Shubham Nazare <shubham4443@gmail.com>
pkg/timer/timerSync.go Outdated Show resolved Hide resolved
Signed-off-by: Shubham Nazare <shubham4443@gmail.com>
@sanketsudake sanketsudake merged commit 69470a6 into fission:main Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating timetrigger without --cron flag is not updating the timetrigger
3 participants