Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses proper way to get server URL #587

Merged
merged 1 commit into from Mar 29, 2018
Merged

Uses proper way to get server URL #587

merged 1 commit into from Mar 29, 2018

Conversation

vishal-biyani
Copy link
Member

@vishal-biyani vishal-biyani commented Mar 29, 2018

There were two problems with fission fn logs implementation on client side:

  1. In case of error, it was returning null so user feedback was missing that there is an error in getting logs

  2. After port forward implementation, the proper way to get server URL was missing in GetLogDB

That was the reason that test_function_log.sh was failing.


This change is Reviewable

@vishal-biyani vishal-biyani changed the title Uses proper way to get server URL, fixes #582 Uses proper way to get server URL Mar 29, 2018
@vishal-biyani
Copy link
Member Author

Confirmation that fission function logs worked:
[SUCCESS]: /test_logging/test_function_logs.sh

@life1347
Copy link
Member

LGTM

@vishal-biyani vishal-biyani merged commit a8482a8 into master Mar 29, 2018
@vishal-biyani vishal-biyani deleted the influx_log_issue branch March 29, 2018 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants