Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses a real go project to showcase vendor example so glide works #828

Merged
merged 3 commits into from Aug 1, 2018

Conversation

vishal-biyani
Copy link
Member

@vishal-biyani vishal-biyani commented Jul 29, 2018

The issue for this PR is explained in #823

Right now a standard go lang project is used but I am ok with creating a small simple Go project in Fission repo and then use that as a dependency for Go vendor example. As long as the project used resolves to an appropriate path by glide - it works.

@life1347 Do you mind taking a look at this please.


This change is Reviewable

@life1347
Copy link
Member

life1347 commented Jul 29, 2018

Ooops, sorry I didn't know that will break glide up -v.
I think its good idea to add a real go dependency and make it more realistic, let's keep it. But since its a dependency only for example, I suggest adding the following lines into glide.yaml to avoid adding unnecessary dependencies in glide.yaml.

excludeDirs:
- examples
- hack
- test

@vishal-biyani
Copy link
Member Author

I tried excludeDirs but that could not fix Glide issue. I will check once more if I made some mistake in adding that and confirm here.

@life1347
Copy link
Member

I tested with glide version: 10.3.1

# glide.yaml
package: github.com/fission/fission
excludeDirs:
- examples
- hack
- test
import:
...

Before adding

[WARN]	Unable to checkout go/vendordir/test
[ERROR]	Error looking for go/vendordir/test: Cannot detect VCS
...
[ERROR]	Failed to retrieve a list of dependencies: Error resolving imports

After

glide up -v without error.

@vishal-biyani
Copy link
Member Author

I will update this PR and close other one.

@vishal-biyani
Copy link
Member Author

@life1347 updated the PR with excludeDirs added

@vishal-biyani vishal-biyani added this to the 0.10.0 milestone Jul 31, 2018
@life1347
Copy link
Member

life1347 commented Aug 1, 2018

LGTM

@life1347 life1347 merged commit 4356378 into master Aug 1, 2018
@life1347 life1347 deleted the glide_build_fix branch August 1, 2018 15:55
garyyeap pushed a commit to garyyeap/fission that referenced this pull request Sep 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants