Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update arstechnica.com.txt #217

Merged
merged 2 commits into from Nov 9, 2016
Merged

Update arstechnica.com.txt #217

merged 2 commits into from Nov 9, 2016

Conversation

sztanpet
Copy link
Contributor

@sztanpet sztanpet commented Nov 4, 2016

The exact same as arstechnica.co.uk.txt because it works perfectly

The exact same as arstechnica.co.uk.txt because it works perfectly
@sztanpet
Copy link
Contributor Author

sztanpet commented Nov 7, 2016

Oh, and this fixes the problem of arstechnica.com articles are not downloaded past the first page

@fivefilters
Copy link
Owner

Thank you for this. Is there a reason why the other rules in the site config files have been removed? E.g. native_ad_clue? If it's just the single_page_link that you've tested, let us know and we'll just amend that line.

@sztanpet
Copy link
Contributor Author

sztanpet commented Nov 7, 2016

I literally just copied the UK sites and tested with both single and multi-page articles in wallabag, it worked perfectly.

@fivefilters fivefilters merged commit e4e882a into fivefilters:master Nov 9, 2016
@fivefilters
Copy link
Owner

Thank you! 👍

@sztanpet
Copy link
Contributor Author

This doesnt seem to work, I tested my own changes but the one that was applied is not the same.
Only a single page is downloaded, never all the pages this way (the original problem).

@sztanpet
Copy link
Contributor Author

Oh, the version installed by the latest wallabag update didn't contain this change yet, nevermind :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants