Merge pull request #25 from fivetran/bugfix/evancole-untitled-casting

bugfix/evancole-untitled-casting update
fivetran · Apr 19, 2022 · cc402ff · cc402ff
2 parents 728d874 + 5867b42
commit cc402ff
Show file tree

Hide file tree

Showing 82 changed files with 458 additions and 452 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,9 @@
+# dbt_quickbooks_source v0.5.0
+## 🚨 Breaking Changes 🚨
+- It was discovered that IDs from the source tables can sometimes be strings. The previous build of the package interpreted all IDs as integers. To ensure the package operates as intended, the package has been updated to cast all IDs to the string datatype. If you were leveraging the end models in downstream analysis, this change could break your join conditions. Be sure to be aware of any join conditions you may have downstream before upgrading your QuickBooks package. (#36)[https://github.com/fivetran/dbt_quickbooks/pull/36]. ([#25](https://github.com/fivetran/dbt_quickbooks_source/pull/25)) ([#24](https://github.com/fivetran/dbt_quickbooks_source/pull/24))
+
+## Contributors
+- [@evancole-untitled](https://github.com/evancole-untitled) ([#24](https://github.com/fivetran/dbt_quickbooks_source/pull/24))
 # dbt_quickbooks_source v0.4.0
 🎉 dbt v1.0.0 Compatibility 🎉
 ## 🚨 Breaking Changes 🚨

diff --git a/README.md b/README.md
@@ -25,7 +25,7 @@ Include in your `packages.yml`
 ```yaml
 packages:
   - package: fivetran/quickbooks_source
-    version: [">=0.4.0", "<0.5.0"]
+    version: [">=0.5.0", "<0.6.0"]
 ```
 
 ## Configuration

diff --git a/dbt_project.yml b/dbt_project.yml
@@ -1,7 +1,7 @@
 config-version: 2
 
 name: 'quickbooks_source'
-version: '0.4.0'
+version: '0.5.0'
 
 require-dbt-version: [">=1.0.0", "<2.0.0"]
 

diff --git a/docs/manifest.json b/docs/manifest.json
diff --git a/integration_tests/dbt_project.yml b/integration_tests/dbt_project.yml
@@ -1,5 +1,5 @@
 name: 'quickbooks_source_integration_tests'
-version: '0.3.0'
+version: '0.5.0'
 profile: 'integration_tests'
 config-version: 2
 
@@ -58,4 +58,4 @@ seeds:
 
 clean-targets:
     - target
-    - dbt_modules
+    - dbt_modules
diff --git a/macros/get_account_columns.sql b/macros/get_account_columns.sql
@@ -10,15 +10,15 @@
     {"name": "balance_with_sub_accounts", "datatype": dbt_utils.type_float()},
     {"name": "classification", "datatype": dbt_utils.type_string()},
     {"name": "created_at", "datatype": dbt_utils.type_timestamp()},
-    {"name": "currency_id", "datatype": dbt_utils.type_int()},
+    {"name": "currency_id", "datatype": dbt_utils.type_string()},
     {"name": "description", "datatype": dbt_utils.type_string()},
     {"name": "fully_qualified_name", "datatype": dbt_utils.type_string()},
-    {"name": "id", "datatype": dbt_utils.type_int()},
+    {"name": "id", "datatype": dbt_utils.type_string()},
     {"name": "name", "datatype": dbt_utils.type_string()},
-    {"name": "parent_account_id", "datatype": dbt_utils.type_int()},
+    {"name": "parent_account_id", "datatype": dbt_utils.type_string()},
     {"name": "sub_account", "datatype": "boolean"},
     {"name": "sync_token", "datatype": dbt_utils.type_string()},
-    {"name": "tax_code_id", "datatype": dbt_utils.type_int()},
+    {"name": "tax_code_id", "datatype": dbt_utils.type_string()},
     {"name": "updated_at", "datatype": dbt_utils.type_timestamp()}
 ] %}
 

diff --git a/macros/get_address_columns.sql b/macros/get_address_columns.sql
@@ -5,7 +5,7 @@
     {"name": "city", "datatype": dbt_utils.type_string()},
     {"name": "country", "datatype": dbt_utils.type_string()},
     {"name": "country_sub_division_code", "datatype": dbt_utils.type_string()},
-    {"name": "id", "datatype": dbt_utils.type_int()},
+    {"name": "id", "datatype": dbt_utils.type_string()},
     {"name": "latitude", "datatype": dbt_utils.type_string()},
     {"name": "line_1", "datatype": dbt_utils.type_string()},
     {"name": "line_2", "datatype": dbt_utils.type_string()},

diff --git a/macros/get_bill_columns.sql b/macros/get_bill_columns.sql
@@ -5,22 +5,22 @@
     {"name": "_fivetran_synced", "datatype": dbt_utils.type_timestamp()},
     {"name": "balance", "datatype": dbt_utils.type_float()},
     {"name": "created_at", "datatype": dbt_utils.type_timestamp()},
-    {"name": "currency_id", "datatype": dbt_utils.type_int()},
-    {"name": "department_id", "datatype": dbt_utils.type_int()},
+    {"name": "currency_id", "datatype": dbt_utils.type_string()},
+    {"name": "department_id", "datatype": dbt_utils.type_string()},
     {"name": "doc_number", "datatype": dbt_utils.type_string()},
     {"name": "due_date", "datatype": "date"},
     {"name": "exchange_rate", "datatype": dbt_utils.type_float()},
     {"name": "global_tax_calculation", "datatype": dbt_utils.type_string()},
     {"name": "home_balance", "datatype": dbt_utils.type_float()},
-    {"name": "id", "datatype": dbt_utils.type_int()},
-    {"name": "payable_account_id", "datatype": dbt_utils.type_int()},
+    {"name": "id", "datatype": dbt_utils.type_string()},
+    {"name": "payable_account_id", "datatype": dbt_utils.type_string()},
     {"name": "private_note", "datatype": dbt_utils.type_string()},
-    {"name": "sales_term_id", "datatype": dbt_utils.type_int()},
+    {"name": "sales_term_id", "datatype": dbt_utils.type_string()},
     {"name": "sync_token", "datatype": dbt_utils.type_string()},
     {"name": "total_amount", "datatype": dbt_utils.type_float()},
     {"name": "transaction_date", "datatype": "date"},
     {"name": "updated_at", "datatype": dbt_utils.type_timestamp()},
-    {"name": "vendor_id", "datatype": dbt_utils.type_int()}
+    {"name": "vendor_id", "datatype": dbt_utils.type_string()}
 ] %}
 
 {{ return(columns) }}

diff --git a/macros/get_bill_line_columns.sql b/macros/get_bill_line_columns.sql
@@ -2,22 +2,22 @@
 
 {% set columns = [
     {"name": "_fivetran_synced", "datatype": dbt_utils.type_timestamp()},
-    {"name": "account_expense_account_id", "datatype": dbt_utils.type_int()},
+    {"name": "account_expense_account_id", "datatype": dbt_utils.type_string()},
     {"name": "account_expense_billable_status", "datatype": dbt_utils.type_string()},
-    {"name": "account_expense_class_id", "datatype": dbt_utils.type_int()},
-    {"name": "account_expense_customer_id", "datatype": dbt_utils.type_int()},
+    {"name": "account_expense_class_id", "datatype": dbt_utils.type_string()},
+    {"name": "account_expense_customer_id", "datatype": dbt_utils.type_string()},
     {"name": "account_expense_tax_amount", "datatype": dbt_utils.type_float()},
-    {"name": "account_expense_tax_code_id", "datatype": dbt_utils.type_int()},
+    {"name": "account_expense_tax_code_id", "datatype": dbt_utils.type_string()},
     {"name": "amount", "datatype": dbt_utils.type_float()},
-    {"name": "bill_id", "datatype": dbt_utils.type_int()},
+    {"name": "bill_id", "datatype": dbt_utils.type_string()},
     {"name": "description", "datatype": dbt_utils.type_string()},
-    {"name": "index", "datatype": dbt_utils.type_int()},
+    {"name": "index", "datatype": dbt_utils.type_string()},
     {"name": "item_expense_billable_status", "datatype": dbt_utils.type_string()},
-    {"name": "item_expense_class_id", "datatype": dbt_utils.type_int()},
-    {"name": "item_expense_customer_id", "datatype": dbt_utils.type_int()},
-    {"name": "item_expense_item_id", "datatype": dbt_utils.type_int()},
+    {"name": "item_expense_class_id", "datatype": dbt_utils.type_string()},
+    {"name": "item_expense_customer_id", "datatype": dbt_utils.type_string()},
+    {"name": "item_expense_item_id", "datatype": dbt_utils.type_string()},
     {"name": "item_expense_quantity", "datatype": dbt_utils.type_float()},
-    {"name": "item_expense_tax_code_id", "datatype": dbt_utils.type_int()},
+    {"name": "item_expense_tax_code_id", "datatype": dbt_utils.type_string()},
     {"name": "item_expense_unit_price", "datatype": dbt_utils.type_float()}
 ] %}
 

diff --git a/macros/get_bill_linked_txn_columns.sql b/macros/get_bill_linked_txn_columns.sql
@@ -2,9 +2,9 @@
 
 {% set columns = [
     {"name": "_fivetran_synced", "datatype": dbt_utils.type_timestamp()},
-    {"name": "bill_id", "datatype": dbt_utils.type_int()},
-    {"name": "bill_payment_id", "datatype": dbt_utils.type_int()},
-    {"name": "index", "datatype": dbt_utils.type_int()}
+    {"name": "bill_id", "datatype": dbt_utils.type_string()},
+    {"name": "bill_payment_id", "datatype": dbt_utils.type_string()},
+    {"name": "index", "datatype": dbt_utils.type_string()}
 ] %}
 
 {{ return(columns) }}

diff --git a/macros/get_bill_payment_columns.sql b/macros/get_bill_payment_columns.sql
@@ -3,24 +3,24 @@
 {% set columns = [
     {"name": "_fivetran_deleted", "datatype": "boolean"},
     {"name": "_fivetran_synced", "datatype": dbt_utils.type_timestamp()},
-    {"name": "check_bank_account_id", "datatype": dbt_utils.type_int()},
+    {"name": "check_bank_account_id", "datatype": dbt_utils.type_string()},
     {"name": "check_print_status", "datatype": dbt_utils.type_string()},
     {"name": "created_at", "datatype": dbt_utils.type_timestamp()},
-    {"name": "credit_card_account_id", "datatype": dbt_utils.type_int()},
-    {"name": "currency_id", "datatype": dbt_utils.type_int()},
-    {"name": "department_id", "datatype": dbt_utils.type_int()},
+    {"name": "credit_card_account_id", "datatype": dbt_utils.type_string()},
+    {"name": "currency_id", "datatype": dbt_utils.type_string()},
+    {"name": "department_id", "datatype": dbt_utils.type_string()},
     {"name": "doc_number", "datatype": dbt_utils.type_string()},
     {"name": "exchange_rate", "datatype": dbt_utils.type_float()},
-    {"name": "id", "datatype": dbt_utils.type_int()},
+    {"name": "id", "datatype": dbt_utils.type_string()},
     {"name": "pay_type", "datatype": dbt_utils.type_string()},
-    {"name": "payable_account_id", "datatype": dbt_utils.type_int()},
+    {"name": "payable_account_id", "datatype": dbt_utils.type_string()},
     {"name": "private_note", "datatype": dbt_utils.type_string()},
     {"name": "process_bill_payment", "datatype": "boolean"},
     {"name": "sync_token", "datatype": dbt_utils.type_string()},
     {"name": "total_amount", "datatype": dbt_utils.type_float()},
     {"name": "transaction_date", "datatype": "date"},
     {"name": "updated_at", "datatype": dbt_utils.type_timestamp()},
-    {"name": "vendor_id", "datatype": dbt_utils.type_int()}
+    {"name": "vendor_id", "datatype": dbt_utils.type_string()}
 ] %}
 
 {{ return(columns) }}

diff --git a/macros/get_bill_payment_line_columns.sql b/macros/get_bill_payment_line_columns.sql
@@ -3,18 +3,18 @@
 {% set columns = [
     {"name": "_fivetran_synced", "datatype": dbt_utils.type_timestamp()},
     {"name": "amount", "datatype": dbt_utils.type_float()},
-    {"name": "bill_id", "datatype": dbt_utils.type_int()},
-    {"name": "bill_payment_credit_card_id", "datatype": dbt_utils.type_int()},
-    {"name": "bill_payment_id", "datatype": dbt_utils.type_int()},
-    {"name": "check_id", "datatype": dbt_utils.type_int()},
-    {"name": "credit_card_charge_id", "datatype": dbt_utils.type_int()},
-    {"name": "credit_card_credit_id", "datatype": dbt_utils.type_int()},
-    {"name": "deposit_id", "datatype": dbt_utils.type_int()},
-    {"name": "expense_id", "datatype": dbt_utils.type_int()},
-    {"name": "index", "datatype": dbt_utils.type_int()},
-    {"name": "journal_entry_id", "datatype": dbt_utils.type_int()},
-    {"name": "linked_bill_payment_id", "datatype": dbt_utils.type_int()},
-    {"name": "vendor_credit_id", "datatype": dbt_utils.type_int()}
+    {"name": "bill_id", "datatype": dbt_utils.type_string()},
+    {"name": "bill_payment_credit_card_id", "datatype": dbt_utils.type_string()},
+    {"name": "bill_payment_id", "datatype": dbt_utils.type_string()},
+    {"name": "check_id", "datatype": dbt_utils.type_string()},
+    {"name": "credit_card_charge_id", "datatype": dbt_utils.type_string()},
+    {"name": "credit_card_credit_id", "datatype": dbt_utils.type_string()},
+    {"name": "deposit_id", "datatype": dbt_utils.type_string()},
+    {"name": "expense_id", "datatype": dbt_utils.type_string()},
+    {"name": "index", "datatype": dbt_utils.type_string()},
+    {"name": "journal_entry_id", "datatype": dbt_utils.type_string()},
+    {"name": "linked_bill_payment_id", "datatype": dbt_utils.type_string()},
+    {"name": "vendor_credit_id", "datatype": dbt_utils.type_string()}
 ] %}
 
 {{ return(columns) }}

diff --git a/macros/get_bundle_columns.sql b/macros/get_bundle_columns.sql
@@ -6,7 +6,7 @@
     {"name": "created_at", "datatype": dbt_utils.type_timestamp()},
     {"name": "description", "datatype": dbt_utils.type_string()},
     {"name": "fully_qualified_name", "datatype": dbt_utils.type_string()},
-    {"name": "id", "datatype": dbt_utils.type_int()},
+    {"name": "id", "datatype": dbt_utils.type_string()},
     {"name": "name", "datatype": dbt_utils.type_string()},
     {"name": "print_grouped_items", "datatype": "boolean"},
     {"name": "purchase_cost", "datatype": dbt_utils.type_float()},

diff --git a/macros/get_bundle_item_columns.sql b/macros/get_bundle_item_columns.sql
@@ -2,8 +2,8 @@
 
 {% set columns = [
     {"name": "_fivetran_synced", "datatype": dbt_utils.type_timestamp()},
-    {"name": "bundle_id", "datatype": dbt_utils.type_int()},
-    {"name": "item_id", "datatype": dbt_utils.type_int()},
+    {"name": "bundle_id", "datatype": dbt_utils.type_string()},
+    {"name": "item_id", "datatype": dbt_utils.type_string()},
     {"name": "item_quantity", "datatype": dbt_utils.type_float()}
 ] %}
 

diff --git a/macros/get_credit_memo_columns.sql b/macros/get_credit_memo_columns.sql
@@ -6,30 +6,30 @@
     {"name": "apply_tax_after_discount", "datatype": "boolean"},
     {"name": "balance", "datatype": dbt_utils.type_float()},
     {"name": "bill_email", "datatype": dbt_utils.type_string()},
-    {"name": "billing_address_id", "datatype": dbt_utils.type_int()},
-    {"name": "class_id", "datatype": dbt_utils.type_int()},
+    {"name": "billing_address_id", "datatype": dbt_utils.type_string()},
+    {"name": "class_id", "datatype": dbt_utils.type_string()},
     {"name": "created_at", "datatype": dbt_utils.type_timestamp()},
-    {"name": "currency_id", "datatype": dbt_utils.type_int()},
+    {"name": "currency_id", "datatype": dbt_utils.type_string()},
     {"name": "custom_p_o_number", "datatype": dbt_utils.type_string()},
-    {"name": "customer_id", "datatype": dbt_utils.type_int()},
+    {"name": "customer_id", "datatype": dbt_utils.type_string()},
     {"name": "customer_memo", "datatype": dbt_utils.type_string()},
-    {"name": "department_id", "datatype": dbt_utils.type_int()},
+    {"name": "department_id", "datatype": dbt_utils.type_string()},
     {"name": "doc_number", "datatype": dbt_utils.type_string()},
     {"name": "email_status", "datatype": dbt_utils.type_string()},
     {"name": "exchange_rate", "datatype": dbt_utils.type_float()},
     {"name": "global_tax_calculation", "datatype": dbt_utils.type_string()},
     {"name": "home_balance", "datatype": dbt_utils.type_float()},
     {"name": "home_total_amount", "datatype": dbt_utils.type_float()},
-    {"name": "id", "datatype": dbt_utils.type_int()},
-    {"name": "payment_method_id", "datatype": dbt_utils.type_int()},
+    {"name": "id", "datatype": dbt_utils.type_string()},
+    {"name": "payment_method_id", "datatype": dbt_utils.type_string()},
     {"name": "print_status", "datatype": dbt_utils.type_string()},
     {"name": "private_note", "datatype": dbt_utils.type_string()},
     {"name": "remaining_credit", "datatype": dbt_utils.type_float()},
-    {"name": "sales_term_id", "datatype": dbt_utils.type_int()},
-    {"name": "shipping_address_id", "datatype": dbt_utils.type_int()},
+    {"name": "sales_term_id", "datatype": dbt_utils.type_string()},
+    {"name": "shipping_address_id", "datatype": dbt_utils.type_string()},
     {"name": "sync_token", "datatype": dbt_utils.type_string()},
     {"name": "total_amount", "datatype": dbt_utils.type_float()},
-    {"name": "total_tax", "datatype": dbt_utils.type_int()},
+    {"name": "total_tax", "datatype": dbt_utils.type_string()},
     {"name": "transaction_date", "datatype": dbt_utils.type_timestamp()},
     {"name": "updated_at", "datatype": dbt_utils.type_timestamp()}
 ] %}

diff --git a/macros/get_credit_memo_line_columns.sql b/macros/get_credit_memo_line_columns.sql
@@ -3,30 +3,30 @@
 {% set columns = [
     {"name": "_fivetran_synced", "datatype": dbt_utils.type_timestamp()},
     {"name": "amount", "datatype": dbt_utils.type_float()},
-    {"name": "bundle_id", "datatype": dbt_utils.type_int()},
+    {"name": "bundle_id", "datatype": dbt_utils.type_string()},
     {"name": "bundle_quantity", "datatype": dbt_utils.type_float()},
-    {"name": "credit_memo_id", "datatype": dbt_utils.type_int()},
+    {"name": "credit_memo_id", "datatype": dbt_utils.type_string()},
     {"name": "description", "datatype": dbt_utils.type_string()},
     {"name": "description_service_date", "datatype": dbt_utils.type_timestamp()},
-    {"name": "description_tax_code_id", "datatype": dbt_utils.type_int()},
-    {"name": "discount_account_id", "datatype": dbt_utils.type_int()},
-    {"name": "discount_class_id", "datatype": dbt_utils.type_int()},
+    {"name": "description_tax_code_id", "datatype": dbt_utils.type_string()},
+    {"name": "discount_account_id", "datatype": dbt_utils.type_string()},
+    {"name": "discount_class_id", "datatype": dbt_utils.type_string()},
     {"name": "discount_discount_percent", "datatype": dbt_utils.type_float()},
     {"name": "discount_percent_based", "datatype": "boolean"},
-    {"name": "discount_tax_code_id", "datatype": dbt_utils.type_int()},
-    {"name": "index", "datatype": dbt_utils.type_int()},
-    {"name": "sales_item_account_id", "datatype": dbt_utils.type_int()},
-    {"name": "sales_item_class_id", "datatype": dbt_utils.type_int()},
+    {"name": "discount_tax_code_id", "datatype": dbt_utils.type_string()},
+    {"name": "index", "datatype": dbt_utils.type_string()},
+    {"name": "sales_item_account_id", "datatype": dbt_utils.type_string()},
+    {"name": "sales_item_class_id", "datatype": dbt_utils.type_string()},
     {"name": "sales_item_discount_amount", "datatype": dbt_utils.type_float()},
     {"name": "sales_item_discount_rate", "datatype": dbt_utils.type_float()},
-    {"name": "sales_item_item_id", "datatype": dbt_utils.type_int()},
+    {"name": "sales_item_item_id", "datatype": dbt_utils.type_string()},
     {"name": "sales_item_quantity", "datatype": dbt_utils.type_float()},
     {"name": "sales_item_service_date", "datatype": dbt_utils.type_timestamp()},
-    {"name": "sales_item_tax_code_id", "datatype": dbt_utils.type_int()},
+    {"name": "sales_item_tax_code_id", "datatype": dbt_utils.type_string()},
     {"name": "sales_item_unit_price", "datatype": dbt_utils.type_float()},
-    {"name": "sub_total_item_id", "datatype": dbt_utils.type_int()}
+    {"name": "sub_total_item_id", "datatype": dbt_utils.type_string()}
 ] %}
 
 {{ return(columns) }}
 
-{% endmacro %}
+{% endmacro %}