diff --git a/CHANGELOG.md b/CHANGELOG.md index ad50e48..f63fcb3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -36,6 +36,13 @@ - `dbt.current_timestamp_backcompat` - `dbt.current_timestamp_in_utc_backcompat` - `packages.yml` has been updated to reflect new default `fivetran/fivetran_utils` version, previously `[">=0.3.0", "<0.4.0"]` now `[">=0.4.0", "<0.5.0"]`. + +## Bug Fixes +- Adjusted the `get_ad_group_report_hourly_columns`, `get_ad_report_hourly_columns`, and `get_campaign_report_hourly_columns` macros to ensure the passthrough variables are included in the returned columns and propogate within downstream models. ([#5](https://github.com/fivetran/dbt_tiktok_ads_source/pull/5)) + +## Contributors +- [@andysmv](https://github.com/andysmv) ([#5](https://github.com/fivetran/dbt_tiktok_ads_source/pull/5)) + # dbt_tiktok_ads_source v0.2.0 PR [#3](https://github.com/fivetran/dbt_tiktok_ads_source/pull/3) applies the following updates: ## 🎉 Feature Enhancements 🎉 diff --git a/macros/get_ad_group_report_hourly_columns.sql b/macros/get_ad_group_report_hourly_columns.sql index aebb57b..18496e1 100644 --- a/macros/get_ad_group_report_hourly_columns.sql +++ b/macros/get_ad_group_report_hourly_columns.sql @@ -28,8 +28,8 @@ {"name": "video_watched_6_s", "datatype": dbt.type_numeric()} ] %} -{{ return(columns) }} - {{ fivetran_utils.add_pass_through_columns(columns, var('tiktok_ads__ad_group_hourly_passthrough_metrics')) }} -{% endmacro %} \ No newline at end of file +{{ return(columns) }} + +{% endmacro %} diff --git a/macros/get_ad_report_hourly_columns.sql b/macros/get_ad_report_hourly_columns.sql index 7254e66..34b3a12 100644 --- a/macros/get_ad_report_hourly_columns.sql +++ b/macros/get_ad_report_hourly_columns.sql @@ -28,8 +28,8 @@ {"name": "video_watched_6_s", "datatype": dbt.type_numeric()} ] %} -{{ return(columns) }} - {{ fivetran_utils.add_pass_through_columns(columns, var('tiktok_ads__ad_hourly_passthrough_metrics')) }} -{% endmacro %} \ No newline at end of file +{{ return(columns) }} + +{% endmacro %} diff --git a/macros/get_campaign_report_hourly_columns.sql b/macros/get_campaign_report_hourly_columns.sql index fa201df..a17d4c4 100644 --- a/macros/get_campaign_report_hourly_columns.sql +++ b/macros/get_campaign_report_hourly_columns.sql @@ -28,8 +28,8 @@ {"name": "video_watched_6_s", "datatype": dbt.type_numeric()} ] %} -{{ return(columns) }} - {{ fivetran_utils.add_pass_through_columns(columns, var('tiktok_ads__campaign_hourly_passthrough_metrics')) }} -{% endmacro %} \ No newline at end of file +{{ return(columns) }} + +{% endmacro %}