[FEATURE] Support underscore in the condition_value of a row_condition - #5393
Merged
austiezr merged 3 commits intoJul 6, 2022
Conversation
✅ Deploy Preview for niobium-lead-7998 canceled.
|
sp1thas
changed the title
condition_value of a row_conditioncondition_value of a row_condition
AFineDayFor
approved these changes
Jun 29, 2022
AFineDayFor
left a comment
AFineDayFor
left a comment
Contributor
There was a problem hiding this comment.
Thank you very much for identifying this and addressing it 🙇
| ops = (gt ^ lt ^ ge ^ le ^ eq).setResultsName("op") | ||
| fnumber = Regex(r"[+-]?\d+(?:\.\d*)?(?:[eE][+-]?\d+)?").setResultsName("fnumber") | ||
| condition_value = Suppress('"') + Word(f"{alphanums}.").setResultsName( | ||
| condition_value = Suppress('"') + Word(f"{alphanums}._").setResultsName( |
sp1thas
changed the title
condition_value of a row_conditioncondition_value of a row_condition
|
What would be involved in getting this merged? Maybe @sp1thas would need to rebase to develop? I have some long format tables and being able to allow "_" where each row is a metric name of some sort will be really useful. |
Contributor
Author
|
I was about to ask the same @andrewm4894 . Based on #5387 (which is quite recent), merging commis into |
austiezr
enabled auto-merge (squash)
July 6, 2022 15:22
Shinnnyshinshin
pushed a commit
that referenced
this pull request
Jul 7, 2022
…ps://github.com/great-expectations/great_expectations into feature/GREAT-1009/remaining-migration-for-init * 'feature/GREAT-1009/remaining-migration-for-init' of https://github.com/great-expectations/great_expectations: [MAINTENANCE] Update cli with new default simple checkpoint name (#5450) [MAINTENANCE] Add unit and integration tests for Splitting on Divided Integer (#5449) support underscore in condition value (#5393) Remove checkpoint from top level of schema since it is captured in `meta` (#5445) [MAINTENANCE] Add checkpoint name to validation results (#5442)
Shinnnyshinshin
pushed a commit
that referenced
this pull request
Jul 7, 2022
…eature/GREAT-954/data-assistant-logic-migration * feature/GREAT-1009/remaining-migration-for-init: clean up [MAINTENANCE] Update cli with new default simple checkpoint name (#5450) [MAINTENANCE] Add unit and integration tests for Splitting on Divided Integer (#5449) support underscore in condition value (#5393) Remove checkpoint from top level of schema since it is captured in `meta` (#5445) [MAINTENANCE] Add checkpoint name to validation results (#5442)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
_) in a condition_valueThis PR aims to allow the user to add an underscore in the condition value of a row condition. For instance, after merging this PR, the following expectation is going to work instead of raising:
ConditionParserError: unable to parse condition: col("foo")=="a_b"{ "data_asset_type": null, "expectation_suite_name": "foo", "expectations": [ { "expectation_type": "expect_column_values_to_be_between", "kwargs": { "column": "foo", "min_value": 1, "max_value": 2, "condition_parser": "great_expectations__experimental__", "row_condition": "col(\"foo\")==\"a_b\"" } } ] }Definition of Done
Please delete options that are not relevant.
Thank you for submitting!