Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlighting code blocks #6

Closed
gokaygurcan opened this issue Jan 15, 2019 · 6 comments
Closed

Highlighting code blocks #6

gokaygurcan opened this issue Jan 15, 2019 · 6 comments

Comments

@gokaygurcan
Copy link

Is your feature request related to a problem? Please describe.
Hi,
I was checking https://fixmie.com/ and the first screenshot (you can see it below) was a bit.. obscure. Having normal text and code recommendations in the same format makes things a bit harder to understand.

Describe the solution you'd like
Instead of replying

should replace errors.New(fmt.Sprintf("something %d", x)) with fmt.Errorf("something %d", x)

maybe it'd be better to reply like

should replace errors.New(fmt.Sprintf("something %d", x)) with fmt.Errorf("something %d", x)

Describe alternatives you've considered
As an alternative, it might even highlight correctly but replying like:

should replace

errors.New(fmt.Sprintf("something %d", x))

with

fmt.Errorf("something %d", x)

Additional context
Here we go, that screenshot from the webpage:
image

@welcome
Copy link

welcome bot commented Jan 15, 2019

Thank you for creating the issue! We'll get back to you shortly with additional information.

@gokaygurcan
Copy link
Author

Well, I must say, I'm not using the tool so IDK how that "suggested change" block looks like. If it's working fine, then I'd suggest to change that text completely. No need to mention the same changes in two places I guess.

@fatih
Copy link
Member

fatih commented Jan 15, 2019

Hi @gokaygurcan

Thanks for the suggestion. I'll have to look how to format it, should be an easy task.

No need to mention the same changes in two places I guess.

This is just one example, sometimes the text describes why the change was made. It depends on the fixer itself and every suggestion has a text, it needs to be something. But these are little improvements we can make over the course of developing Fixmie. Thanks again, I'll close this once I have some time to improve them :)

@gokaygurcan
Copy link
Author

Thanks! Looks like a nice tool, I wish I was writing some Go ^_^

@fatih
Copy link
Member

fatih commented Jan 26, 2019

This is partly fixed now with the following change.

screen shot 2019-01-26 at 03 15 35

Multi line message is not supported yet so I'll take a look at them in near future. It's not a high priority for now. Thanks for the feedback again. It's pushed to product.

@fatih fatih closed this as completed Jan 26, 2019
@gokaygurcan
Copy link
Author

Perfect! It seems a lot more descriptive and clear now. Thanks again and good luck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants