Active closure of socket upon reconnection#15
Merged
fizista merged 2 commits intofizista:masterfrom Nov 24, 2022
elvis-epx:active-dis
Merged
Active closure of socket upon reconnection#15fizista merged 2 commits intofizista:masterfrom elvis-epx:active-dis
fizista merged 2 commits intofizista:masterfrom
elvis-epx:active-dis
Conversation
This PR explicitly calls disconnect() before connect(), and makes sure disconnect() is idempotent and does nos raise exceptions. At least in ESP32, connection sockets are limited in number (8 or 10) and they pile up if not explicitly closed and/or garbage-collected. Calling connect() a number of times on umqtt.simple or umqtt.simple2 without explicit closure/gc eventually fails.
If connect() raises an exception, it may happen that self.sock contains a socket but the poller members are still None.
Owner
|
Thank you. |
|
Thanks from me too. I just ran into this problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR explicitly calls disconnect() before connect(), and makes sure disconnect() is idempotent and does nos raise exceptions.
At least in ESP32, connection sockets are limited in number (8 or 10) and they pile up if not explicitly closed and/or garbage-collected. Calling connect() a number of times on umqtt.simple or umqtt.simple2 without explicit closure/gc eventually fails.