Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ghc 8.2 #44

Merged
merged 12 commits into from Jan 17, 2017

Conversation

Projects
None yet
2 participants
@phadej
Copy link
Collaborator

commented Jan 12, 2017

(will) resolve #43 (and #42).

@phadej phadej force-pushed the phadej:ghc-8.2 branch from 956e304 to 08d1b70 Jan 12, 2017

@phadej

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 12, 2017

This is directly based on ekmett/bytes#32 with small additions.

I can revert .travis.yml to the HEAD state (and use stack). But I like this setup.

Also for the record: 0.3 version uses closed type families, so GHC >= 7.8 is hard requirement.

@fizruk

fizruk approved these changes Jan 13, 2017

@fizruk

This comment has been minimized.

Copy link
Owner

commented Jan 13, 2017

@phadej you now have write access to this repository.

@phadej

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 13, 2017

I'm still experimenting with making setup.lhs and doctests.hsc copy&pasteable across wider set of packages. It starts to look good already.

@phadej

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 13, 2017

Thanks for the rights!

So you are ok with not testing stack.yaml in Travis? (then it might make sense to use only single one, for the dev)

@phadej phadej force-pushed the phadej:ghc-8.2 branch from ac0e999 to b473c6a Jan 13, 2017

@phadej phadej force-pushed the phadej:ghc-8.2 branch from 82a46ff to f15e04e Jan 13, 2017

@phadej

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 13, 2017

Sorry for the spam. But I'd wait with this until Ben & Ryan are commented on this (in other repos PR, distributive), before continuing with this.

I'm also not 100% sure that non-released Cabal api won't change, but I guess it's still ok to push this to Hackage as setup-depends are in place.

phadej added some commits Jan 13, 2017

@fizruk

This comment has been minimized.

Copy link
Owner

commented Jan 17, 2017

@phadej where's the discussion this is blocked on?

@phadej

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 17, 2017

I pushed a commit, if it's green with 8.2, then feel free to merge

@fizruk fizruk merged commit cf75536 into fizruk:master Jan 17, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@fizruk

This comment has been minimized.

Copy link
Owner

commented Jan 17, 2017

Great! Thanks!

@phadej phadej deleted the phadej:ghc-8.2 branch Jan 17, 2017

@fizruk fizruk referenced this pull request Jan 17, 2017

Closed

Compile error with base-4.6 #42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.