Skip to content
This repository


Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
  • 286 commits
  • 359 files changed
  • 79 contributors
This comparison is big! We're only showing the most recent 250 commits
Jun 09, 2008
Joshua Peek Fixed ambiguous first argument warning in ArrayExtTest. d2a3723
Joshua Peek Fixed deprecated call to Dependencies in plugin loader test. 8b65473
Jun 10, 2008
Jeremy Kemper Inflector -> ActiveSupport::Inflector 319941e
Jeremy Kemper PostgreSQL: insert looks up pk and sequence name if not given. [#384
Jun 11, 2008
Grant Hollingworth Performance: speed up Hash#except. [#382 state:resolved] a797375
Ruy Asan TimeZone -> ActiveSupport::TimeZone. [#387 state:resolved] 011b5ed
Jan De Poorter Add :validate option to associations. [#301 state:resolved]
Signed-off-by: Pratik Naik <>
Pratik Disable validations for associated belongs_to record by default e25e272
Pratik Update docs to reflect 71bf75 535b988
Jan De Poorter Fix FormOptionsHelper tests.
Signed-off-by: Pratik Naik <>
Pratik Silence TimeZone warning 20442ac
Jan De Poorter Added some has_many tests
Signed-off-by: Pratik Naik <>
Antonio Cangiano Fixed non-standard SQL generated by preloading has_and_belongs_to_man…
…y association. [#394 state:resolved]
Ben Munat Add :from option to calculations. [#397 state:resolved] 67e8ec0
Jun 13, 2008
Pratik Make rescue template xhtml compatible [Sam Ruby] [#415 state:resolved] f1a1e55
Jun 17, 2008
Andrew Kaspick Correct code example in dom_id docs. [#437 state:resolved] 4d83e9d
Amos King verify :redirect_to => :back should redirect to the referrer. [#280 s…

Signed-off-by: Pratik Naik <>
George Ogata Fix observers that use after_find. [#375 state:resolved]
Signed-off-by: Pratik Naik <>
Fix url_for with no arguments when default_url_options is not explici…
…tly defined. [#339 state:resolved]

Signed-off-by: Pratik Naik <>
Jun 18, 2008
Jeremy Kemper Update Rakefiles to connect to wrath as current user. Use ssh config …
…to set a different user.
Jeremy Kemper Add pdoc task to toplevel Rakefile df98d4b
Jeremy Kemper Generate rdoc for all .rb files except those in vendor 4d45c09
Jeremy Kemper Generate rdoc for all .rb files except those in vendor 99b429f
Jeremy Kemper Exclude lib/actionpack.rb from rdoc 644e2cd
Jeremy Kemper Exclude lib/activeresource.rb from rdoc 8c95c8e
Jeremy Kemper Use native include/exclude instead of doing it by hand 55bd351
Jeremy Kemper Add lib/rails/*.rb to rdoc a4752c6
Jeremy Kemper Use rdoc exclude edb48d6
Jeremy Kemper Add dummy pdoc task to railties a46d09f
Jeremy Kemper Add toplevel rdoc and pdoc tasks 7084e88
Jeremy Kemper Require ssh publisher in toplevel Rakefile 1256bba
Jeremy Kemper fix toplevel pdoc task 271b834
Jeremy Kemper Add toplevel doc to .gitignore 8c0ce21
Jun 19, 2008
Brandon Keepers fix eager loading with dynamic finders 7827b07
risk danger olson Add the gem load paths before the framework is loaded, so certain gem…
…s like RedCloth and BlueCloth can be frozen. [#320 state:resolved]
risk danger olson Fix discrepancies with loading rails/init.rb from gems. [#324 state:r…
Jun 20, 2008
Jeremy Kemper Fall back to #to_s for cache key expansion 5f52da4
Jun 22, 2008
Jeremy Kemper Horo rdoc template 3a05ba6
Jeremy Kemper Remove incorrect master entries from 2-1-stable CHANGELOGs. Mark upco…
…ming stuff as 2.1.1 (next release) instead of Edge.
Diego Algorta MySQL: rename_column preserves default values. [#466 state:resolved] 9855d0b
Tarmo Tänav Named bind variables can now be used with postgresql-style typecasts
For example :conditions => ['stringcol::integer = :var', { :var => 10 }]
will no longer raise an exception about ':integer' having a missing value.
Jeremy Kemper Changelog for 509374e 44656db
Tarmo Tänav Fixed that scopes defined with a string name could not be composed b31b6ef
Michael Raidel ActiveRecord::Migrator#run records version-state after migrating. [#369
… state:resolved]
Ian Warshak Only use DROP ... IF EXISTS for PostgreSQL 8.2 or later. [#400 state:…
Fixed polymorphic_url to be able to handle singleton resources.
Example usage:
polymorphic_url([:admin, @user, :blog, @post]) # => admin_user_blog_post_url(@user, @post)

[#461 state:resolved]
Mark Catley Fix column collision with named_scope and :joins. [#46 state:resolved] 3558a50
Daniel Morrison Partial updates don't update lock_version if nothing changed. [#426 s…
Tarmo Tänav Always treat integer :limit as byte length. [#420 state:resolved] a2eab62
Jeremy Kemper Check for mocha gem without requiring the lib. [#403 state:resolved] 8636df7
Jun 23, 2008
Jeremy Kemper Revert "Check for mocha gem without requiring the lib. [#403 state:re…

This reverts commit 8636df7.
Cheah Chu Yeow Allow script/about to run in production mode instead of failing with …
…a cryptic const_missing error.

[#370 state:resolved]
Jeremy Kemper Treat any limit > 4 as bigint fe81af7
Jeremy Kemper Test for tinyint 6051249
Jun 24, 2008
Jimmy Baker Patched HTML::Document#initialize call to Node.parse so that it inclu…
…des the strict argument. [#330 state:resolved]
Jun 27, 2008
Jan De Poorter Make sure associated has_many/habtm objects get saved even when :vali…
…date => false is used. [#486 state:resolved]

Signed-off-by: Pratik Naik <>
Jeremy Kemper MySQL: treat integer with :limit => 11 as a display width, not byte s…
…ize, for backward-compatibility.
Cheah Chu Yeow Allow single quote (the ' character) in the middle of URL when auto_l…
…ink-ing. [#471 state:resolved]

Signed-off-by: Pratik Naik <>
Pratik Ensure observer test inherits from ActiveSupport::TestCase 0fd6371
Jeremy Kemper Fix typo in apparently-dead will_unload? method. a42599d
Tim Chater Dirty: recognize when an integer changes from zero to blank. [#433 st…
Jun 29, 2008
Pratik Ensure FormBuilder date helpers respects html_options. [#506 state:re…
…solved] [Pascal Ehlert]

Signed-off-by: Pratik Naik <>


Jul 02, 2008
Ensure proper output when submit_tag is used with :disabled_with. [#388
… state:resolved]

Signed-off-by: Pratik Naik <>
Pratik Ensure AssociationCollection#size considers all unsaved record. [#305
…state:resolved] [sds]

Signed-off-by: Pratik Naik <>
Tim Haines Make sure render :template works with :locals. [#524 state:resolved]
Signed-off-by: Pratik Naik <>
Jul 03, 2008
Michael Koziarski Deprecate define_javascript_functions in favour of javascript_include…
Jul 04, 2008
David Lowenfels Add :tokenizer option to validates_length_of. [#507 state:resolved]
Signed-off-by: Pratik Naik <>
Pratik Use ActiveSupport::TimeZone in time:zones rake tasks 9d8fdc9
Jeremy Kemper Fix rdoc for Filters::ClassMethods ef0bd72
Jul 09, 2008
Michael Koziarski Deprecate the limited follow_redirect in functional tests. If you wis…
…h to follow redirects, use integration tests.
Jul 10, 2008
Clemens Kofler Added notes to Routing documentation and routes.rb regarding defaults…
… routes opening the whole application for GET requests

Signed-off-by: Michael Koziarski <>
Jul 14, 2008
Geoff Buesing Fix TimeWithZone unmarshaling: coerce unmarshaled Time instances to u…
…tc, because Ruby's marshaling of Time instances doesn't respect the zone
Jul 15, 2008
Geoff Buesing TimeWithZone: when crossing DST boundary, treat Durations of days, mo…
…nths or years as variable-length, and all other values as absolute length. A time + 24.hours will advance exactly 24 hours, but a time + will advance 23-25 hours, depending on the day. Ensure consistent behavior across all advancing methods
Jeremy Kemper PostgreSQL: don't dump :limit => 4 for integers e8c5859
Tarmo Tänav Fixed mysql change_column_default to not make the column always nulla…

Also added change_column_null to both mysql and sqlite to keep the api features closer to postgresql.

[#617 state:resolved]
Jeremy Kemper Give more info on missing gems and abort instead of printing a warnin…
…g. App can begin in incomplete state otherwise.
Ryan Kinderman Ensure plugins' rake tasks are loaded before application's rake tasks. [
#259 state:resolved]

Signed-off-by: Pratik Naik <>
Pratik Fix that Rails::InfoController tests ea1c1f2
Joshua Peek Wrap date part value method tests inside a uses mocha block. 88ff9e1
Jeremy Kemper Performance: faster Object.subclasses_of 0a11165
Jeremy Kemper Remove dead, unused vendor/db2.rb 7df1078
Fixes parsing deep nested resources from XML. [#380 state:resolved] 70a34cd
Jeremy Kemper PostgreSQL: use 'INSERT ... RETURNING id' for 8.2 and later. 44363ba
Jeremy Kemper Fix quoting in test_counting_with_single_conditions 4c6eed0
Jeremy Kemper Don't dump schema for every test run, just when migrations are run b6d0eba
Tarmo Tänav Oops, already had a postgresql_version method!

Carl Porth Ensure Rails::Generator quotes file names while generating diff. [#264

Signed-off-by: Pratik Naik <>
Ricardo Otero Ensure script/plugin unsource 'Usage' text is correct. [#526 state:re…

Signed-off-by: Pratik Naik <>
Michael Koziarski Tighten the rescue clause here to prevent hiding strange mock related…
… errors behind the line offset test
Michael Koziarski Tighten the rescue clause when dealing with invalid instance variable…
… names in form_helper.
Chris Cherry Allow Infinity (1.0/0.0) to pass validates_numericality_of. [#354 sta…

Signed-off-by: Pratik Naik <>
Joshua Peek Fixed teardown method typo (plus whitespace) dde5d26
Michael Koziarski Use require_dependency 'application' not require in the console boots…
…traps to avoid requiring application.rb twice
Tarmo Tänav Fixed that create database statements would always include "DEFAULT N…
…ULL" (Nick Sieger) [#334 status:committed]


Tarmo Tänav Fixed test_rename_nonexistent_column for PostgreSQL
Also fixed ability to run migration_test.rb alone

[#616 state:resolved]
Gabe da Silveira Add assert_sql helper method to check for specific SQL output in Acti…
…ve Record test suite. [#325 state:resolved]

Signed-off-by: Pratik Naik <>
Fix integer quoting issues in association preload. [#602 state:resolved]
Signed-off-by: Pratik Naik <>
Tarmo Tänav Fixed postgresql limited eager loading for the case where scoped :ord…
…er was present
Tarmo Tänav SQLite: rename_column raises if the column doesn't exist.
[#622 state:resolved]
Jason Dew Add block syntax to HasManyAssociation#build. [#502 state:resolve]
Signed-off-by: Pratik Naik <>
Emilio Tagua update_counters should update nil values.
This allows counter columns with default null instead of requiring default 0.

[#493 state:resolved]
Observers not longer add an after_find method to the observed class.
[#625 state:resolved]
David Lowenfels requiring rubygems version 1.1.1 97ac788
Joshua Peek Added Object#metaclass 98dd722
Joshua Peek Run callbacks from object's metaclass e0846c8
Jul 16, 2008
Joshua Peek Revert "Added Object#metaclass"
This reverts commit 98dd722.
Joshua Peek Revert "Run callbacks from object's metaclass"
This reverts commit e0846c8.
Jul 24, 2008
Tarmo Tänav Use :namespace instead of :path_prefix for finding controller. [#544

:namespace is supposed to be the module where controller exists.
:path_prefix can contain anything, including variables, which
makes it unsuitable for determining the module for a controller.

Signed-off-by: Pratik Naik <>


Signed-off-by: Michael Koziarski <>
Jul 30, 2008
José Valim Initializer skips prepare_dispatcher if Action Controller isn't in us…
…e. [#721 state:resolved]
Emilio Tagua Prototype helpers should generate Element.insert instead of Insertion…
….new, which has been deprecated in Prototype 1.6.
José Valim Initializer requires ERB explicitly instead of assuming Action Pack l…
…oaded it. [#722 state:resolved]
Michael Koziarski Set config.active_record.timestamped_migrations = false to have migra…
…tions with numeric prefix instead of UTC timestamp. [#446 state:resolved]

Signed-off-by: Pratik Naik <>
Jul 31, 2008
Michael Koziarski Ensure dbconsole includes the -p parameter to mysql as intended 0498d32
Aug 06, 2008
Jeremy Kemper JRuby: improve constantize performance. [#410 state:resolved] 88eec83
Aug 12, 2008
Tom Lea Serialized attributes will now always be saved even with partial_upda…
…tes turned on.

Signed-off-by: Michael Koziarski <>
[#788 state:committed]
Tarmo Tänav Fixed Time/Date object serialization
Time/Date objects used to be converted to_s instead of to_uaml
which made them unserializable.
Aug 13, 2008
Jeffrey Hardy Account for the possibility of a nil options argument to CompressedMe…
Aug 15, 2008
Tarmo Tänav Use type_condition method for hmt STI condition 6660206
Aug 20, 2008
Jeremy Kemper Rely on quieter db:test:load task 482e8fe
Aug 24, 2008
Tarmo Tänav Don't set "NULL" as a constraint on nullable columns [#398 state:reso…

This is already the default and adding it breaks SQL standards compatibility.


Joshua Peek Namespaced StringQuestioneer under ActiveSupport. 5b6fb7c
Joshua Peek Renamed StringQuestioneer to StringInquirer.
Signed-off-by: Tarmo Tänav <>
Tarmo Tänav Always require activesupport, even if its constant already exists
This is needed because the existance of the ActiveSupport
constant by itself does not guarantee that the whole library
has been loaded.

Also load the StringInquirer in the Rails#env method as
the it might be called inside the initializer block
before activesupport itself has been loaded.
Jeremy Kemper link_to_function and button_to_function shouldn't modify their option…
…s hashes
Cheah Chu Yeow Ensure url_for(nil) falls back to url_for({}). [#472 state:resolved]
Signed-off-by: Pratik Naik <>
Pratik Slightly faster DateTime#to_json. [#598 state:resolved] [Alex Zepeda] 50c73c2
Use fully-qualified controller name when logging. [#600 state:resolved]
Signed-off-by: Pratik Naik <>
Joshua Peek All 2xx requests are considered successful [#217 state:resolved] 0e10e93
Johan Sørensen Ensure mail_to label is obfuscated for javascript encoding. [#294 sta…

Signed-off-by: Pratik Naik <>
Daniel Ensure script/generate finds generators from symlinked plugins. [#449

Signed-off-by: Pratik Naik <>
Marcos Tapajós Use full path in database tasks so commands will work outside of Rail…
…s root [#612 state:resolved]

Signed-off-by: Joshua Peek <>
David Heinemeier Hansson Fixed that AssetTagHelper#compute_public_path shouldn't cache the ass…
…et_host along with the source or per-request proc's won't run [DHH]
Joachim Garth Make sure association preloading works with full STI class name [#465

Signed-off-by: Pratik Naik <>
Daniel Use klass.sti_name to make sure associations take store_full_sti_clas…
…s into account. [#671 state:resolved]

Signed-off-by: Pratik Naik <>
Miles Georgi Make script/plugin work with svn+ssh urls. [#662 state:resolved]
Signed-off-by: Pratik Naik <>
George Ogata Make observers define #after_find in the model only if needed.
[#676 state:resolved]
Signed-off-by: Michael Koziarski <>
Jan De Poorter Fix that label_tag doesn't take a symbol for a name. [#719 state:reso…

Signed-off-by: Pratik Naik <>
Tarmo Tänav Fixed test_joins_with_namespaced_model_should_use_correct_type for po…

Signed-off-by: Michael Koziarski <>
Tarmo Tänav Cast value to string in validates_uniqueness_of if the column is of t…
…ext type

This fixes an error for postgresql where "text_column = 100" fails in version 8.3

Signed-off-by: Michael Koziarski <>
Tarmo Tänav Fixed negative default integer parsing for Postgresql 8.3.3
Signed-off-by: Michael Koziarski <>
Emilio Tagua In javascript helpers option[:type] = :synchronous should work as des…
…cribed in docs.

Signed-off-by: Michael Koziarski <>
Benjamin Sandofsky Make requiring gems optional.
Signed-off-by: Michael Koziarski <>
[#743 state:resolved]
Ernie Miller Fixed AssociationCollection#<< resulting in unexpected values in @target
when :uniq => true

Signed-off-by: Michael Koziarski <>
Michalis Polakis Alias subquery used in calculations, to provide better compatibility …
…with databases such as MonetDB

Signed-off-by: Michael Koziarski <>
Signed-off-by: Tom Ward <>
[#796 state:committed]
Eloy Durán Fix ActiveRecord::NamedScope::Scope#respond_to? [#818 state:resolved]
Signed-off-by: Pratik Naik <>
Tarmo Tänav Fixed STI type condition for eager loading of associations
Signed-off-by: Pratik Naik <>
Nathan Witmer Updated has_and_belongs_to_many association to fix :finder_sql interp…
…olation. [#848 state:resolved]

Signed-off-by: Pratik Naik <>
Tarmo Tänav Test for eager loading of STI subclasses from htm associations
Signed-off-by: Pratik Naik <>
Miles Georgi PostgreSQL: fix transaction bug that can occur if you call change_col…
…umn with invalid parameters

[#861 state:resolved]
Ryan Bates Support find_all on named scopes. [#730 state:resolved]
Signed-off-by: Pratik Naik <>
Fix that has_one natural assignment to already associated record. [#854
… state:resolved]

Signed-off-by: Pratik Naik <>
Xavier Noria Fix has_many#count_records. [#865 state:resolved]
Signed-off-by: Pratik Naik <>
Philip Hallstrom Fix generated WHERE IN query for named scopes. [#583 state:resolved]
Signed-off-by: Pratik Naik <>
Tom Lea Fix incorrect signature for NamedScope#respond_to? [#852 state:resolved]
Signed-off-by: Pratik Naik <>
Peter Wagenet Don't interpret decimals as table names in ActiveRecord::Associations…
…::ClassMethods#references_eager_loaded_tables? [#532 state:resolved]

Signed-off-by: Pratik Naik <>
Tarmo Tänav Properly quote CREATE DATABASE parameters in postgresql [#771 state:r…
Tarmo Tänav Fixed ordering in test_find_in_association_with_custom_finder_sql_and…
Patrick Reagan Ensure t.timestamps respects options. [#828 state:resolved]
Signed-off-by: Pratik Naik <>
Tarmo Tänav Clear prefix_parameters cache when setting prefix

Joshua Peek Update uses_mocha in ActionMailer and ActiveResource 482f6aa
Tarmo Tänav Merge branch '2-1-unsure' into tarmo_2-1-unsure 11d9669
Aug 25, 2008
Tarmo Tänav Fixed merge mistake for 38a0d5c 0528758
Michael Koziarski Merge commit 'tarmo/2-1-stable' into upgrade f477676
Frederick Cheung Fix preloading of has_one through associations
[#903 state:resolved]

Signed-off-by: Jeremy Kemper <>
Frederick Cheung Implement old-skool eagerloading for has_one :through
Signed-off-by: Jeremy Kemper <>
Tarmo Tänav Load the first and not the last has_one result when doing join-based …
…eager loading

This matters when the has_one is defined with an order in which case
there is an expectation that the first one will be loaded.

[#904 state:resolved]

Signed-off-by: Jeremy Kemper <>
Tarmo Tänav Cache migrated versions list in Migrator and use it to fetch the late…
…st migrated version name [#845 state:resolved]

Also optimized Migrator#current_version class method to fetch
only the latest version number and not all of them.

With this change no matter how many migrations there are the
schema_migrations table is only SELECTed from once.

Signed-off-by: Jeremy Kemper <>
Tarmo Tänav Use DECIMAL instead of INTEGER when casting as mysql doesn't work wit…
…h just "INTEGER" and other databases don't like "UNSIGNED" which mysql requires

And don't mask exceptions.

Signed-off-by: Jeremy Kemper <>
Jeremy Kemper fix tests relying on implicit ordering 698357b
Aug 26, 2008
Jeremy Kemper fix another ordering failure 71c53f6
Jeremy Kemper typo 8f03357
Jeremy Kemper um.. yeah 813290d
Tarmo Tänav Include mysql older than 5.1.23 in the 5.1 series in the list of thos…
…e that can't handle NULL defaults

Signed-off-by: Jeremy Kemper <>
Jeremy Kemper PostgreSQL: pg driver expects nil instead of empty string for missing…
… user/pass
Tarmo Tänav Create mysql binary_fields table with latin1 character set as with ut…
…f8 all the limits would have to be divided by 3 to get the expected text types

Signed-off-by: Jeremy Kemper <>
Jeremy Kemper fix tests relying on implicit ordering eab7611
Jeremy Kemper Include people and readers fixtures to fix test isolation error ad51406
Tarmo Tänav Back to fetching all versions in ruby instead of letting SQL do it as…
… it's difficult to get all databases to convert the text value to a number with the same SQL

Signed-off-by: Jeremy Kemper <>
Tarmo Tänav Added missing fixtures for tests which fail to run independently if r…
…un after schema reset

Signed-off-by: Michael Koziarski <>
Tarmo Tänav Just look at sql_type when testing that the correct database-specific…
… type was used

Signed-off-by: Michael Koziarski <>
Joshua Peek Updated bundled TZInfo gem to version 0.3.9 for Ruby 1.9 compat b4d13a9
Aug 27, 2008
Fix two has_one :through errors
* Set the association target on assignment;
* Reset target to nil on reset, rather than empty array.

Signed-off-by: Michael Koziarski <>
[#895 state:committed]
Fix Ruby's Time marshaling bug in pre-1.9 versions of Ruby: utc insta…
…nces are now correctly unmarshaled with a utc zone instead of the system local zone [#900 state:resolved]
Tim Haines Add TestUploadFile.content_type= to match Request.UploadedFile
[#920 state:resolved]

Signed-off-by: Jeremy Kemper <>
Jeremy Kemper respond_to? passes along splat args to avoid introducing the second a…
…rg if it was omitted
Lars Kanis PostgreSQL: fix quote_string for certain old pg drivers. [#94 state:r…
Michael Klishin Request#remote_ip handles the uncommon case that REMOTE_ADDR is a com…
…ma-separated list.

[#523 state:resolved]

Signed-off-by: Jeremy Kemper <>
Tom Lea Dirty: treat two changes resulting in the original value as being unc…

[#798 state:resolved]

Signed-off-by: Jeremy Kemper <>
Tarmo Tänav Alias included associations if needed when doing a count
[#302 state:resolved]

Signed-off-by: Jeremy Kemper <>
Tarmo Tänav Implement count limit/offset support for has_many associations
[#348 state:resolved]

Signed-off-by: Jeremy Kemper <>
Brad Folkens Reinstate Range#step default argument.
[#595 state:resolved]

Signed-off-by: Jeremy Kemper <>
Aug 28, 2008
Jeremy Kemper Work around frozen Date memoization d4e668b
Jeremy Kemper Date#freeze bug doesn't affect Ruby 1.9 e27e1f0
Aug 29, 2008
Michael Koziarski Fix NamedScope regex so methods containing "an" get delegated to prox…

Signed-off-by: Michael Koziarski <>
[#901 state:committed]


Michael Koziarski Fix parentheses warnings 08b0c8d
Tarmo Tänav Make case insensitive validates_uniqueness_of use unicode aware downc…
…ase method. [#932 state:resolved]

Signed-off-by: Michael Koziarski <>



Signed-off-by: Tarmo Tänav <>
Jeremy Kemper Fix bad merge from e21ed3e e7df4ce
r6p Format related patches to support serializing data out in the correct…
… format with correct http request headers per http method type [#450 state:resolved]

Signed-off-by: Tarmo Tänav <>
Signed-off-by: Jeremy Kemper <>
Nathaniel Bibler Added optional rake doc:app TITLE environment parameter
[#939 state:resolved]

Signed-off-by: Jeremy Kemper <>
Aug 30, 2008
Emilio Tagua Allow prototype functions to receive position parameter as a symbol.
[#887 state:resolved]

Signed-off-by: Jeremy Kemper <>
Sep 02, 2008
Michael Koziarski Merge rexml-expansion-fix gem into activesupport. 5a56dbb
Sep 03, 2008
Inline help text was incorrectly telling user to uncomment line to us…
…e default local time. User should comment the line to use default local time.

Signed-off-by: Michael Koziarski <>
[#960 state:committed]
Sep 04, 2008
Tarmo Tänav Don't run 32bit dependant assertions in 64bit environments
Signed-off-by: Michael Koziarski <>
risk danger olson use mocha for TimeZone mocking in Form Options helper tests
Signed-off-by: Tarmo Tänav <>
Signed-off-by: Michael Koziarski <>
Joshua Peek Stub out timestamped_migrations in generator tests ae378b9
Hongli Lai Plugin locator: sort directory listing because we can't assume that t…
…he OS will do it for us. This fixes some unit test failures.
Michael Koziarski Handle the case where there is no ivar set.
This happens on jruby due to a bug, but also on historically marshalled data.
David Heinemeier Hansson Push to temporary gem server until Wrath is back in shape 7398874
David Heinemeier Hansson Prepare for release of 2.1.1 02d610b
David Heinemeier Hansson Forgot to resolve one file d4eb3c0
Sep 07, 2008
Matt Jones Ensure routing optimizations are cleared when new routes are added [#981

Signed-off-by: Joshua Peek <>
Sep 09, 2008
Michael Koziarski Remove the Version check as it's not always available. 2689445
Michael Koziarski Interpolation requires double quotes 437d716
David Heinemeier Hansson Add back version check for REXML but account for different constants 8f38577
David Heinemeier Hansson Add back version check for REXML but account for different constants …
…[state:committed #969]
David Heinemeier Hansson Merge branch '2-1-stable' of into 2-1-stable e48c62f
Sep 10, 2008
David Heinemeier Hansson Fixed FormTagHelper#submit_tag with :disable_with option wouldn't sub…
…mit the button's value when was clicked #633 [Jose Fernandez]
David Heinemeier Hansson Remove merge clutter 42cfffc
fixed association preloading to use = instead of IN when there's only…
… one record

[#1013 state:committed]

Signed-off-by: Jeremy Kemper <>
Sep 11, 2008
Fixes validates_uniquness_of problem with case insensitive string con…
…taining newline characters

Signed-off-by: Michael Koziarski <>
Sep 13, 2008
Mislav Marohnić Ensure Hash#except is allowed on a frozen hash. References #382
Signed-off-by: Pratik Naik <>
Sep 14, 2008
Geoff Buesing Multiparameter attributes skip time zone conversion for time-only col…
…umns [#1030 state:resolved]
Sep 18, 2008
Michael Koziarski Revert API breaking changes in ActiveResource in preparation for 2.1.2
Revert "Format related patches to support serializing data out in the correct format with correct http request headers per http method type"

This reverts commit 16b9a55.
Tarmo Tänav Fix incorrect validates_uniqueness_of doc claiming default case_insen…
…sitivity [#883 state:resolved]

Signed-off-by: Michael Koziarski <>
Michael Koziarski Deprecate country_select for 2.1, it's gone in 2.2
You can install the country_select plugin to obtain the same, possibly controversial, list of countries.
Sep 20, 2008
adevadeh applied patch to fix the associations with blocks in modules bug from…
… an old trac ticket
risk danger olson Merge branch '2-1-stable' of into 2-1-stable 2075824
Sep 22, 2008
Michael Koziarski Bump the Version constants to align with the *next* release rather th…
…an the previous release.

This allows people tracking non-release gems or git submodules to use the constants.
Sep 23, 2008
Adds failed test case for slicing hash with indifferent access with s…
…ymbol keys

Signed-off-by: Michael Koziarski <>
Michael Koziarski slice now returns indifferent hash if called on one
Signed-off-by: Michael Koziarski <>

[#1096 state:committed]


Michael Koziarski Revert "Performance: faster Object.subclasses_of" as it breaks jruby.
This reverts commit 0a11165.
Sep 24, 2008
Michael Koziarski Handle quoting multibyte strings with newlines.
[#999 state:committed]
Michael Koziarski Partially revert 185fe2e
We shouldn't quote the unpack command's requirement as it's passed through GemRunner which takes care of it for us.
Sep 26, 2008
Tarmo Tänav Ignore all exceptions for validates_acceptance_of columns fetch so it…
… can run even without a database connection

Signed-off-by: Michael Koziarski <>
Sep 29, 2008
Will Bryant wrote a test showing eager loading's misbehavior (sanitizing against …
…the wrong table) when the association has a :conditions hash

Signed-off-by: Michael Koziarski <>
Will Bryant fix eager loading's :condition sanitizing expanding against the wrong…
… table

Signed-off-by: Michael Koziarski <>
[#1101 state:commited]
Oct 03, 2008
Michael Koziarski Remove AS for oracle compatibility 6370ff3
Oct 04, 2008
Pratik Ensure Model.sum and Model.avg typecast appropriately. [#1066 state:r…

Model.sum delegates typecasting to the column being summed. If that's not feasible, returns a string.
Model.avg always returns big decimal.
Oct 05, 2008
Michael Koziarski Reference more detailed documentation on the country_select issue rat…
…her than just recommending the country_select plugin.
Michael Koziarski Update to 2.2 in the warnings cebfb5c
Oct 09, 2008
Matt Jones Fix script/console --sandbox warning. [#1194 state:resolved]
Signed-off-by: Pratik Naik <>
Oct 17, 2008
Pratik Fix Brasilia timezone. [#1180 state:resolved] 4a256d7
Oct 19, 2008
Michael Koziarski Sanitize the URLs passed to redirect_to to prevent a potential respon…
…se spli

CGI.rb and mongrel don't do any sanitization of the contents of HTTP headers
Geoff Buesing Bundle TzInfo version 0.3.11 75b017c
Geoff Buesing TimeWithZone#freeze: preload instance variables so that we can actual…
…ly freeze
Oct 20, 2008
Geoff Garside Bump active_support/vendor.rb tzinfo version number [#1237 state:reso…
Oct 21, 2008
Pratik Fix script/generate warning d956280
Oct 23, 2008
David Heinemeier Hansson Make ready for the 2.1.2 release 4cf5f9a
David Heinemeier Hansson Fix changelog for 2.1.1, all the 2.2.0 changes had snuck in there e929d74
David Heinemeier Hansson Latest release.rb script 15af6b3