Skip to content
Commits on Jan 6, 2015
  1. @jyurek

    Don't assume we have Rails.env if we have Rails

    jyurek committed
    As referenced in #1739
    
    Just because the `Rails` constant is defined, it doesn't mean we're
    actually in a Rails app. Since there are people who use Paperclip
    outside of Rails, and there's no reason we shouldn't be able to run in
    those situations. This commit checks for `Rails.env` instead of just
    checking for `Rails` and assuming `Rails.env` works.
Commits on Dec 23, 2014
  1. @jyurek

    Merge pull request #1738 from asanghi/patch-1

    jyurek committed
    typo in NEWS
  2. @asanghi

    typo in NEWS

    asanghi committed
    typo! :nails:
Commits on Dec 19, 2014
  1. @jyurek

    Merge pull request #1724 from soramugi/appraisal_install

    jyurek committed
    Change to `appraisal install`
  2. @jyurek

    Revert "Make id partitioning for string similar to integer"

    Oliver Heard committed with jyurek
    This reverts commit 0680225.
Commits on Dec 12, 2014
  1. @jyurek

    Merge pull request #1725 from soramugi/full_test

    jyurek committed
    Full test not a here ?
  2. @soramugi

    Full test not a here ?

    soramugi committed
  3. @soramugi

    Change to `appraisal install`

    soramugi committed
    executing to `rake appraisal:install` log
    
    ```
    `rake appraisal:install` task is deprecated and will be removed soon. Please use `appraisal install`.
    ```
Commits on Dec 9, 2014
  1. @jyurek

    Update cocaine dependency

    jyurek committed
    Cocaine changes how it returns the supplied path in 0.5.5. While this
    has no effect on the workings of Paperclip in a normal capacity, it does
    break the tests. This change fixes that and updates the cocaine
    dependency to 0.5.5.
  2. @jyurek

    v4.2.1

    jyurek committed
Commits on Dec 8, 2014
  1. @jyurek

    Add Rails 4.2 to Appraisals

    jyurek committed
  2. @richpeck @jyurek

    Updated Readme.md

    richpeck committed with jyurek
    Added manual installation instructions for `file.exe` on Windows
  3. @ahmadsherif @jyurek
Commits on Dec 5, 2014
  1. @jyurek

    Fog upgraded how expiring_urls are made

    jyurek committed
    Turns out that between fog 1.22.0 and fog 1.25.0, there was a change to
    how fog builds S3 expiring URLs. This changes to test to be the common
    point between the two versions. All we need to do here is make sure that
    the expiring URL is being constructed.
    
    In the process, this also updates all the appraisal-generated
    Gemfiles.
    
    Also, in the process, this meant I had to take away the builder version
    restriction. This was put in so that `bundle`ing wouldn't take forever,
    but I'm unsire whether this needed to happen with this version or if
    builder just needed to be separate from the Gemfile. I'm commimtting
    this and asking the people who reported the problem. If you don't see a
    revet commit, everything was fine.
  2. @jyurek

    Revert "Fast to slowly spec"

    jyurek committed
    This reverts commit ae3ec23.
  3. @jyurek

    Revert "remove whitespace, not main gemspec"

    jyurek committed
    This reverts commit 8d70c19.
  4. @jyurek

    Revert "Fog upgraded how expiring_urls are made"

    jyurek committed
    This reverts commit 8e0eb4c.
  5. @jyurek

    Fog upgraded how expiring_urls are made

    jyurek committed
    During the fixing of the previous commit, the tests broken. Turns out
    that between fog 1.22.0 and fog 1.25.0, there was a change to how fog
    builds S3 expiring URLs. This changes to test to be the common point
    between the two versions. All we need to do here is make sure that the
    expiring URL is being constructed.
    
    In the process, this also updates all the appraisal-generated Gemfiles.
    
    Also, in the process, this meant I had to take away the builder version
    restriction. This was put in so that `bundle`ing wouldn't take forever,
    but I'm unsire whether this needed to happen with this version or if
    builder just needed to be separate from the Gemfile. I'm commimtting
    this and asking the people who reported the problem. If you don't see a
    revet commit, everything was fine.
  6. @soramugi @jyurek
  7. @soramugi @jyurek

    Fast to slowly spec

    soramugi committed with jyurek
    ```
     paperclip $ rspec spec/paperclip/integration_spec.rb --profile 1
    Testing against version 4.1.7
    .........................[deprecated] I18n.enforce_available_locales will default to true in the future. If you really want to skip validation of your locale you can set I18n.enforce_available_locales = false to avoid this message.
    .........
    
    Finished in 15.19 seconds (files took 0.60155 seconds to load)
    34 examples, 0 failures
    
    Top 1 slowest examples (9.54 seconds, 62.8% of total time):
      Paperclip Many models at once does not exceed the open file limit
        9.54 seconds ./spec/paperclip/integration_spec.rb:18
    ```
    
    to
    
    ```
     paperclip $ rspec spec/paperclip/integration_spec.rb --profile 1
    Testing against version 4.1.7
    .........................[deprecated] I18n.enforce_available_locales will default to true in the future. If you really want to skip validation of your locale you can set I18n.enforce_available_locales = false to avoid this message.
    .........
    
    Finished in 10.95 seconds (files took 0.59585 seconds to load)
    34 examples, 0 failures
    
    Top 1 slowest examples (5.33 seconds, 48.7% of total time):
      Paperclip Many models at once does not exceed the open file limit
        5.33 seconds ./spec/paperclip/integration_spec.rb:18
    ```
    
    at trim indent
  8. @jyurek
Commits on Nov 14, 2014
  1. @soramugi
Commits on Nov 7, 2014
  1. @jyurek

    Be able to escale URL characters more easily

    jyurek committed
    Including + now.
Commits on Oct 24, 2014
  1. @jyurek
  2. @jyurek

    Adds a 'validate_media_type' option, default: true

    jyurek committed
    Many people have complained that the Media Type Spoof Detection does not
    work properly for their files. While whitelisting is available for some
    files, it's not a general solution. This option leaves the "secure by
    default" of the media checker in place, but allows people to turn it off
    completely if they so choose.
Commits on Sep 25, 2014
  1. @jyurek
  2. @keichan34 @jyurek

    Pass options through to the underlying adapter.

    keichan34 committed with jyurek
    Column-specific options can be specified by using its name,
    for example:
    
    ```
    t.attachment :avatar, created_at: { index: true }
    ```
  3. @jyurek

    Merge pull request #1654 from maximeg/patch-1

    jyurek committed
    Fix: Typo in README
  4. @jyurek

    Merge pull request #1657 from vasinov/master

    jyurek committed
    Update README.md
Commits on Sep 22, 2014
  1. @vasinov

    Update README.md

    vasinov committed
    Added a security shield from Hakiri. It shows how secure gem dependencies are.
Commits on Sep 18, 2014
  1. @maximeg

    FIx: Typo in README

    maximeg committed
Commits on Sep 15, 2014
  1. @jyurek
  2. @jyurek

    Merge pull request #1650 from jastix/master

    jyurek committed
    Update zh-TW.yml
  3. @jyurek

    Merge pull request #1649 from jastix/patch-1

    jyurek committed
    Update zh-CN.yml
  4. @jyurek

    Merge pull request #1636 from princemaple/master

    jyurek committed
    Add all sorts of Chinese translations
Something went wrong with that request. Please try again.