Improve Symbol detection #26

Open
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@MSch

MSch commented Aug 18, 2013

No description provided.

@fjl

This comment has been minimized.

Show comment
Hide comment
@fjl

fjl Aug 19, 2013

Owner

This does several things at once.

Regarding the exclusion of meta.function.erlang: Is this really necessary? I
use Sublime-Erlang every day and no additional definitions show up in the symbol list.
Can you provide an example module where this happens? Which version
of Sublime Text do you use?

Regarding the change in the symbol list prefixes: they were like that in the original
textmate package and I changed them on purpose. I think they are easier to read
as words, and you don't run into sigil-namespace problems for stuff like yecc rules.
If there was real demand from more than one person, I would give in and change them,
though. Please also keep in mind that the prefixes are used by the Goto Definition code and need
to be changed there as well.

Owner

fjl commented Aug 19, 2013

This does several things at once.

Regarding the exclusion of meta.function.erlang: Is this really necessary? I
use Sublime-Erlang every day and no additional definitions show up in the symbol list.
Can you provide an example module where this happens? Which version
of Sublime Text do you use?

Regarding the change in the symbol list prefixes: they were like that in the original
textmate package and I changed them on purpose. I think they are easier to read
as words, and you don't run into sigil-namespace problems for stuff like yecc rules.
If there was real demand from more than one person, I would give in and change them,
though. Please also keep in mind that the prefixes are used by the Goto Definition code and need
to be changed there as well.

@MSch

This comment has been minimized.

Show comment
Hide comment
@MSch

MSch Aug 26, 2013

Sorry for taking so long to get back to you, I was on vacation :)

I'm using Sublime Text 3:

Example file: https://gist.github.com/6339279

Here simple calls to functions show up in the symbol list:

2013-08-26 at 10 38

I fixed that:

2013-08-26 at 10 38

We haven't done anything with yecc rules in our codebase yet, and probably won't, so I did not consider that at all.
Guess it could maybe be an option?

MSch commented Aug 26, 2013

Sorry for taking so long to get back to you, I was on vacation :)

I'm using Sublime Text 3:

Example file: https://gist.github.com/6339279

Here simple calls to functions show up in the symbol list:

2013-08-26 at 10 38

I fixed that:

2013-08-26 at 10 38

We haven't done anything with yecc rules in our codebase yet, and probably won't, so I did not consider that at all.
Guess it could maybe be an option?

@nox

This comment has been minimized.

Show comment
Hide comment
@nox

nox Aug 26, 2013

Contributor

The prefixes should rather be left alone and the calls not be included in the symbol list.

Contributor

nox commented Aug 26, 2013

The prefixes should rather be left alone and the calls not be included in the symbol list.

@fjl

This comment has been minimized.

Show comment
Hide comment
@fjl

fjl Aug 26, 2013

Owner

Here's how it looks like for me:

screenshot

I have no idea why those symbols show up on your machine.
What other plugins do you have installed? Also, is there anything related to Erlang in your User package?

Owner

fjl commented Aug 26, 2013

Here's how it looks like for me:

screenshot

I have no idea why those symbols show up on your machine.
What other plugins do you have installed? Also, is there anything related to Erlang in your User package?

@MSch

This comment has been minimized.

Show comment
Hide comment
@MSch

MSch Aug 26, 2013

Hm, there's nothing in my User package, but I have kept the Erlang.sublime-package that comes with Sublime Text.

These are all my plugins:

BracketHighlighter/         Package Control/            Slim/                       Theme - Soda/               WordHighlight/
Focus Last Tab/             Ruby/                       Sublime-Erlang/             TrailingSpaces/
Git/                        SCSS/                       SublimeBlockCursor/         User/
GitGutter/                  ScopeHunter/                SyncedSideBar/              Vintageous/
Origami/                    SideBarEnhancements/        Theme - Default/            Vintageous_Plugin_Surround/

MSch commented Aug 26, 2013

Hm, there's nothing in my User package, but I have kept the Erlang.sublime-package that comes with Sublime Text.

These are all my plugins:

BracketHighlighter/         Package Control/            Slim/                       Theme - Soda/               WordHighlight/
Focus Last Tab/             Ruby/                       Sublime-Erlang/             TrailingSpaces/
Git/                        SCSS/                       SublimeBlockCursor/         User/
GitGutter/                  ScopeHunter/                SyncedSideBar/              Vintageous/
Origami/                    SideBarEnhancements/        Theme - Default/            Vintageous_Plugin_Surround/
@fjl

This comment has been minimized.

Show comment
Hide comment
@fjl

fjl Aug 30, 2013

Owner

I don't know how to solve this issue. I think the best thing going forward would be to just blacklist those scopes as you did. Please update the pull request so it contains only the blacklisting of meta.function.erlang and not the prefix changes.

Owner

fjl commented Aug 30, 2013

I don't know how to solve this issue. I think the best thing going forward would be to just blacklist those scopes as you did. Please update the pull request so it contains only the blacklisting of meta.function.erlang and not the prefix changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment