pyerrors/correlators.py: Allowing for None values in pe.Corr.prune #272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
campioru
force-pushed
the
feature/None_prune
branch
from
552c02c to
bff1e4c
Compare
Contributor
Author
|
Hi @fjosw, sorry for missing this - I'm still pretty new to open source contributions! I think I've added a test correctly now - let me know if you'd like me to squash my commits into one, or if I should let you do that yourself. |
fjosw
approved these changes
Oct 19, 2025
Owner
fjosw
left a comment
fjosw
left a comment
There was a problem hiding this comment.
Thanks @campioru, the test looks good. No need to squash the commits on your side, I can do that in the process of merging the pull request 👍
I'll create a new release in a few minutes and publish it via pypi and condaforge such that you can use an official version with your fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #271