Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added menu shown & hidden callbacks #107

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@Phault
Copy link
Contributor

Phault commented Mar 10, 2019

Needed this myself and noticed someone else did too. #95

@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 10, 2019

Coverage Status

Coverage increased (+0.1%) to 97.436% when pulling 65b22b8 on Phault:master into bb14cf1 on fkhadra:master.

@Phault

This comment has been minimized.

Copy link
Contributor Author

Phault commented Mar 10, 2019

Hmmm.. Not sure what to do about the code duplication in unit tests that codeclimate is complaining about. Duplicated code seems kind of expected in unit tests, no?

@fkhadra

This comment has been minimized.

Copy link
Owner

fkhadra commented Mar 10, 2019

Hello @Phault,

Thanks for the PR. I fixed the code climate issue(just needed to approve).

@Phault

This comment has been minimized.

Copy link
Contributor Author

Phault commented Mar 12, 2019

@fkhadra Alright, that sounds good.

@Phault

This comment has been minimized.

Copy link
Contributor Author

Phault commented Mar 21, 2019

@fkhadra I see you assigned me and didn't merge the PR. Am I supposed to do something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.