Feature/Added prop for passing function when close button is clicked #1118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please let me know if this pull request resolves the issue? |
zizhengtai
suggested changes
Jun 7, 2024
README.md
Outdated
| @@ -107,6 +107,12 @@ Support this project with your organization. Your logo will show up here with a | |||
| <a href="https://opencollective.com/react-toastify/organization/8/website"><img src="https://opencollective.com/react-toastify/organization/8/avatar.svg"></a> | |||
| <a href="https://opencollective.com/react-toastify/organization/9/website"><img src="https://opencollective.com/react-toastify/organization/9/avatar.svg"></a> | |||
|
|
|||
| ### ToastContainer Props | |||
There was a problem hiding this comment.
I don't think this should be added here, the README seems to contain only high-level information about the project and not detailed release notes.
package-lock.json
Outdated
There was a problem hiding this comment.
Can we delete this? The project is not using package-lock.json.
yarn.lock
Outdated
There was a problem hiding this comment.
Can you revert these changes? There doesn't seem to be any good reason for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Summary
Added an
onButtonCloseprop to theToastcomponent to allow users to define a callback function that gets called when the close button of a toast is clicked. This enhancement improves the flexibility and usability of the toast component by allowing custom behavior to be executed when the close button is pressed.Changes
Toastcomponent to accept and handle a newonButtonCloseprop.ToastContainercomponent to pass theonButtonCloseprop to eachToastcomponent.onButtonCloseprop.Checklist
master.yarnin the repository root.yarn test).yarn startto test changes in the playground.yarn prettier-all).yarn lint:fix).Additional Information
This feature allows users to pass a callback function that will be called when the toast's close button is clicked, enabling more custom and dynamic behaviors when a toast is dismissed.