Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display default CloseButton when closeButton option set to true #313

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@alanlima
Copy link

alanlima commented Feb 7, 2019

Added new feature suggested on #310 to display the default <CloseButton /> element when set closeButton={true} on toast options which will supersede the same option on ToastContainer when <ToastContainer closeButton={false} />.

I also added a new test to test this new feature and updated the readme.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 7, 2019

Coverage Status

Coverage increased (+0.02%) to 97.545% when pulling d498788 on alanlima:close-button-options into 8fc64cb on fkhadra:master.

@fkhadra

fkhadra approved these changes Mar 8, 2019

@fkhadra

This comment has been minimized.

Copy link
Owner

fkhadra commented Mar 17, 2019

Hey @alanlima,

I forgot to told ya that this PR is 👌!

@alanlima

This comment has been minimized.

Copy link
Author

alanlima commented Mar 17, 2019

Hi @fkhadra
Fantastic, It is good to know.
This is my first PR, so I am happy to receive positive feedback.
Thank very much ;)

fkhadra added a commit that referenced this pull request Mar 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.