Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note on behavior of dismiss() when delaying notification appearance #372

Merged
merged 1 commit into from Jul 15, 2019

Conversation

Projects
None yet
3 participants
@fightingmonk
Copy link
Contributor

commented Jul 9, 2019

Per #371 you cannot dismiss a delayed notification before it appears. This PR adds a note to the docs for Delay notification appearance to make that clear.

Add note on behavior of dismiss() when delaying notification appearance
Per #371 you cannot dismiss a delayed notification before it appears. This PR adds a note to the docs for *Delay notification appearance* to make that clear.
@coveralls

This comment has been minimized.

Copy link

commented Jul 9, 2019

Coverage Status

Coverage remained the same at 94.504% when pulling 319c519 on fightingmonk:patch-1 into a3e23da on fkhadra:master.

@fkhadra

fkhadra approved these changes Jul 9, 2019

Copy link
Owner

left a comment

That's definitely a good Idea

@fkhadra fkhadra merged commit 5269bd4 into fkhadra:master Jul 15, 2019

3 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 94.504%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.