Added unit tests in response to issue #14 #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Minor tweaks to Formatting * Added a section about contribution * Added section about how to test * Added a few words about present and future organization
* Left all existing code in place * Created two new functions to make more modular and easier to test * Moved a few lines of existing code into those two new functions
Updated internal calculations to track both lines added and removed while matching the original contribution and churn calculations Additionally, file change counts were manually reviewed to ensure their correctness.
* Refactored existing code to track line add and line removal * Made sure the code remained true to original churn and contributions counts
Code churn per file
Owner
|
Hi @NewMountain , thanks for your contribution! I've finally have organized a bit here to get some time again to focus on this repo. I will merge your two pull requests, and we can discuss/chat how your participation. I don't think it makes sense to rely on one person (me) as the gatekeeper for this handy tool. Let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @flacle !
As mentioned in issue 14, I would like to help out with the issues in the backlog, but wanted to make sure there were tests in place so that I could be sure I wasn't breaking any existing functionality.
Please let me know what you think and, if you are comfortable with the idea, I would like to help you close out some of the other issues.
Thanks again!
Changes: