Memory leak word embeddings #2018
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-memory-leak-word-embeddings
…-memory-leak-word-embeddings
…so uses cache for get_cached_vec.
Collaborator
|
@whoisjones thanks for adding this! |
|
@whoisjones ,did this update affect and fix memory leak in trained sequence tagger models? In my case, when I deployed flair models with flask and uwsgi, memory increases with time. But I'm not very sure this is because of the flair model but I highly suspect this. |
Collaborator
|
Are you running this from master branch? The update was pushed after the last Flair release so if you install from pip you don't yet have it. |
|
@alanakbik , can I install with |
Collaborator
|
Yes that would work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
functools lru_cache doesn't follow self object's lifetime, thus the memory leak. replaced with methodtools.
closes GH-2013.